Remove timber call for public read only functions#481
Merged
lydiagarms merged 3 commits intomasterfrom Mar 4, 2026
Merged
Conversation
… functions, so we should not call the timber event listener
SwatiEY
previously approved these changes
Mar 4, 2026
jtcoolen
previously approved these changes
Mar 4, 2026
lydiagarms
force-pushed
the
lyd/readOnlyTimber
branch
from
ba14560 to
842c0c7
Compare
lydiagarms
force-pushed
the
lyd/readOnlyTimber
branch
from
842c0c7 to
bbf2757
Compare
SwatiEY
approved these changes
Mar 4, 2026
jtcoolen
approved these changes
Mar 4, 2026
|
🎉 This PR is included in version 1.10.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In api_services.mjs, for read-only functions, the startEventFilter for timber is called. However, for public functions, timber is not necessary. As we only support public read-only functions in Starlight, we should not call startEventFilter.
Checklist
How to test
Screenshots / Evidence (if applicable)