create C++ library and CMake export#186
Merged
KrisThielemans merged 6 commits intomainfrom Mar 26, 2026
Merged
Conversation
Makes PETSIRD usable as a standalone, installed dependency. Specifically, it: * Installs PETSIRD files • Adds a proper PETSIRDConfig.cmake export • Enables downstream projects (e.g. STIR, STIR2PETSIRD) to use find_package(PETSIRD)
xtensor-blas currently does not depend on xtensor (!), so
we have to include it ourselves. Otherwise, the `xtensor` target
is undefined, leading to linker errors downstream ("missing -lxtensor")
- create a STATIC library petsird from the OBJECT library petsird_generated and depend on that - remove xtensor work-around - try to more consistent in project, namespace and filenames to use PETSIRD - a bit more documentation in a few files
Contributor
|
Seems OK. But if you want to me to test it, it will take a few days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as @NikEfth #181 but with cleaned-up file and history (and project version update).
@NikEfth, what do you think? Ok to merge?