Sentinel-1 GRD Analysis Mode#80
Merged
konstntokas merged 24 commits intomainfrom May 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
pont-us
approved these changes
May 5, 2026
Collaborator
pont-us
left a comment
There was a problem hiding this comment.
Looks good, tests pass, notebook works. I made some comments and suggestions, but nothing vital (mainly docs) so feel free to postpone if merging is urgent. My review of the actual calculation parts was very shallow, but doing it thoroughly would take days (starting with Small, 2011...).
Co-authored-by: Pontus Lurcock <pont@talvi.net>
Co-authored-by: Pontus Lurcock <pont@talvi.net>
Co-authored-by: Pontus Lurcock <pont@talvi.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it might help to start with reading the changes in docs, to get a rough overview of the Sen1 processing.