fix(review): address dashboard and docs follow-ups#234
Merged
SantiagoDePolonia merged 1 commit intomainfrom Apr 15, 2026
Merged
fix(review): address dashboard and docs follow-ups#234SantiagoDePolonia merged 1 commit intomainfrom
SantiagoDePolonia merged 1 commit intomainfrom
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Contributor
📝 WalkthroughWalkthroughMultiple dashboard files received accessibility improvements and error-handling enhancements. Documentation was rephrased for clarity, the Makefile added tooling preflight checks, CSS styling was updated for focus states and button consistency, JavaScript error handling was refined, and templates were converted to use semantic button elements with ARIA attributes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@internal/admin/dashboard/static/js/modules/dashboard-layout.test.js`:
- Line 458: The current assertion using assert.match(modelsBlock, /.../) doesn't
explicitly require the new clause about the "effective request `user_path`";
update the regex used in the assert.match call on modelsBlock to include and
anchor the new wording (e.g., require the phrase "effective request `user_path`"
or equivalent exact text) so the help-text test fails if that clause is removed
or altered, ensuring the assertion still checks the rest of the existing
selector-format sentence (provider/model patterns and the managed API
key/user_path behavior).
In `@internal/admin/dashboard/templates/sidebar.html`:
- Around line 50-63: The theme control buttons (elements with class "theme-btn"
and "theme-toggle-mobile" that call setTheme(...) and toggleTheme()) lack
explicit button types causing potential form-submission; add type="button" to
each <button> element for the three theme buttons and the mobile toggle button
so they do not act as submit buttons if placed inside a form.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d3819bf1-ad78-4125-87b4-58a3246ddf9b
📒 Files selected for processing (9)
Makefiledocs/about/benchmarks.mdxdocs/about/values.mdxinternal/admin/dashboard/static/css/dashboard.cssinternal/admin/dashboard/static/js/dashboard.jsinternal/admin/dashboard/static/js/modules/dashboard-layout.test.jsinternal/admin/dashboard/static/js/modules/request-cancellation.test.jsinternal/admin/dashboard/templates/index.htmlinternal/admin/dashboard/templates/sidebar.html
| assert.match(modelsBlock, /class="pagination-btn pagination-btn-primary pagination-btn-with-icon alias-create-btn"[\s\S]*@click="openAliasCreate\(\)"[\s\S]*data-lucide="plus" class="alias-create-icon"[\s\S]*<span>Create Alias<\/span>/); | ||
| assert.match(modelsBlock, /class="pagination-btn pagination-btn-primary pagination-btn-with-icon alias-submit-btn"[\s\S]*:disabled="aliasSubmitting"[\s\S]*data-lucide="plus" class="form-action-icon" x-show="aliasFormMode !== 'edit'"[\s\S]*data-lucide="save" class="form-action-icon" x-show="aliasFormMode === 'edit'"[\s\S]*x-text="aliasSubmitting \? 'Saving\.\.\.' : \(aliasFormMode === 'edit' \? 'Save Alias' : 'Create Alias'\)"/); | ||
| assert.match(modelsBlock, /class="pagination-btn pagination-btn-primary pagination-btn-with-icon model-access-submit-btn"[\s\S]*:disabled="modelOverrideSubmitting"[\s\S]*data-lucide="save" class="form-action-icon"[\s\S]*x-text="modelOverrideSubmitting \? 'Saving\.\.\.' : 'Save Access'"/); | ||
| assert.match(modelsBlock, /The selector uses <code>\/<\/code> for all providers and models, <code>\{provider_name\}\/<\/code> for one provider, or <code>\{provider_name\}\/\{model\}<\/code> for one model\.[\s\S]*managed API key <code>user_path<\/code> when present, otherwise the <code>X-GoModel-User-Path<\/code> request header\./); |
Contributor
There was a problem hiding this comment.
Tighten the selector help-text assertion to cover the new clause explicitly.
The regex still passes without strictly asserting the newly added “effective request user_path” wording, so that part can regress undetected.
🔍 Suggested assertion update
- assert.match(modelsBlock, /The selector uses <code>\/<\/code> for all providers and models, <code>\{provider_name\}\/<\/code> for one provider, or <code>\{provider_name\}\/\{model\}<\/code> for one model\.[\s\S]*managed API key <code>user_path<\/code> when present, otherwise the <code>X-GoModel-User-Path<\/code> request header\./);
+ assert.match(modelsBlock, /The selector uses <code>\/<\/code> for all providers and models, <code>\{provider_name\}\/<\/code> for one provider, or <code>\{provider_name\}\/\{model\}<\/code> for one model\.[\s\S]*<code>user_paths<\/code> is matched against the effective request <code>user_path<\/code>:[\s\S]*managed API key <code>user_path<\/code> when present, otherwise the <code>X-GoModel-User-Path<\/code> request header\./);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| assert.match(modelsBlock, /The selector uses <code>\/<\/code> for all providers and models, <code>\{provider_name\}\/<\/code> for one provider, or <code>\{provider_name\}\/\{model\}<\/code> for one model\.[\s\S]*managed API key <code>user_path<\/code> when present, otherwise the <code>X-GoModel-User-Path<\/code> request header\./); | |
| assert.match(modelsBlock, /The selector uses <code>\/<\/code> for all providers and models, <code>\{provider_name\}\/<\/code> for one provider, or <code>\{provider_name\}\/\{model\}<\/code> for one model\.[\s\S]*<code>user_paths<\/code> is matched against the effective request <code>user_path<\/code>:[\s\S]*managed API key <code>user_path<\/code> when present, otherwise the <code>X-GoModel-User-Path<\/code> request header\./); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@internal/admin/dashboard/static/js/modules/dashboard-layout.test.js` at line
458, The current assertion using assert.match(modelsBlock, /.../) doesn't
explicitly require the new clause about the "effective request `user_path`";
update the regex used in the assert.match call on modelsBlock to include and
anchor the new wording (e.g., require the phrase "effective request `user_path`"
or equivalent exact text) so the help-text test fails if that clause is removed
or altered, ensuring the assertion still checks the rest of the existing
selector-format sentence (provider/model patterns and the managed API
key/user_path behavior).
Comment on lines
+50
to
+63
| <button class="theme-btn" :class="{ active: theme === 'light' }" @click="setTheme('light')" title="Light theme" aria-label="Light theme"> | ||
| <i data-lucide="sun" class="theme-icon" aria-hidden="true"></i> | ||
| </button> | ||
| <button class="theme-btn" :class="{ active: theme === 'system' }" @click="setTheme('system')" title="System" tabindex="-1"> | ||
| <button class="theme-btn" :class="{ active: theme === 'system' }" @click="setTheme('system')" title="System theme" aria-label="System theme"> | ||
| <i data-lucide="monitor" class="theme-icon" aria-hidden="true"></i> | ||
| </button> | ||
| <button class="theme-btn" :class="{ active: theme === 'dark' }" @click="setTheme('dark')" title="Dark" tabindex="-1"> | ||
| <button class="theme-btn" :class="{ active: theme === 'dark' }" @click="setTheme('dark')" title="Dark theme" aria-label="Dark theme"> | ||
| <i data-lucide="moon" class="theme-icon" aria-hidden="true"></i> | ||
| </button> | ||
| </div> | ||
| <button class="theme-toggle-mobile" @click="toggleTheme()" :title="theme === 'light' ? 'Light' : theme === 'dark' ? 'Dark' : 'System'" tabindex="-1"> | ||
| <button class="theme-toggle-mobile" | ||
| @click="toggleTheme()" | ||
| :title="theme === 'light' ? 'Light theme' : theme === 'dark' ? 'Dark theme' : 'System theme'" | ||
| :aria-label="theme === 'light' ? 'Light theme' : theme === 'dark' ? 'Dark theme' : 'System theme'"> |
Contributor
There was a problem hiding this comment.
Add explicit button types on theme controls.
These buttons currently omit type="button", which is flagged by HTMLHint and can cause unintended form submission behavior if markup is ever nested in a form.
🔧 Proposed fix
- <button class="theme-btn" :class="{ active: theme === 'light' }" `@click`="setTheme('light')" title="Light theme" aria-label="Light theme">
+ <button type="button" class="theme-btn" :class="{ active: theme === 'light' }" `@click`="setTheme('light')" title="Light theme" aria-label="Light theme">
@@
- <button class="theme-btn" :class="{ active: theme === 'system' }" `@click`="setTheme('system')" title="System theme" aria-label="System theme">
+ <button type="button" class="theme-btn" :class="{ active: theme === 'system' }" `@click`="setTheme('system')" title="System theme" aria-label="System theme">
@@
- <button class="theme-btn" :class="{ active: theme === 'dark' }" `@click`="setTheme('dark')" title="Dark theme" aria-label="Dark theme">
+ <button type="button" class="theme-btn" :class="{ active: theme === 'dark' }" `@click`="setTheme('dark')" title="Dark theme" aria-label="Dark theme">
@@
- <button class="theme-toggle-mobile"
+ <button type="button" class="theme-toggle-mobile"
`@click`="toggleTheme()"
:title="theme === 'light' ? 'Light theme' : theme === 'dark' ? 'Dark theme' : 'System theme'"
:aria-label="theme === 'light' ? 'Light theme' : theme === 'dark' ? 'Dark theme' : 'System theme'">📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <button class="theme-btn" :class="{ active: theme === 'light' }" @click="setTheme('light')" title="Light theme" aria-label="Light theme"> | |
| <i data-lucide="sun" class="theme-icon" aria-hidden="true"></i> | |
| </button> | |
| <button class="theme-btn" :class="{ active: theme === 'system' }" @click="setTheme('system')" title="System" tabindex="-1"> | |
| <button class="theme-btn" :class="{ active: theme === 'system' }" @click="setTheme('system')" title="System theme" aria-label="System theme"> | |
| <i data-lucide="monitor" class="theme-icon" aria-hidden="true"></i> | |
| </button> | |
| <button class="theme-btn" :class="{ active: theme === 'dark' }" @click="setTheme('dark')" title="Dark" tabindex="-1"> | |
| <button class="theme-btn" :class="{ active: theme === 'dark' }" @click="setTheme('dark')" title="Dark theme" aria-label="Dark theme"> | |
| <i data-lucide="moon" class="theme-icon" aria-hidden="true"></i> | |
| </button> | |
| </div> | |
| <button class="theme-toggle-mobile" @click="toggleTheme()" :title="theme === 'light' ? 'Light' : theme === 'dark' ? 'Dark' : 'System'" tabindex="-1"> | |
| <button class="theme-toggle-mobile" | |
| @click="toggleTheme()" | |
| :title="theme === 'light' ? 'Light theme' : theme === 'dark' ? 'Dark theme' : 'System theme'" | |
| :aria-label="theme === 'light' ? 'Light theme' : theme === 'dark' ? 'Dark theme' : 'System theme'"> | |
| <button type="button" class="theme-btn" :class="{ active: theme === 'light' }" `@click`="setTheme('light')" title="Light theme" aria-label="Light theme"> | |
| <i data-lucide="sun" class="theme-icon" aria-hidden="true"></i> | |
| </button> | |
| <button type="button" class="theme-btn" :class="{ active: theme === 'system' }" `@click`="setTheme('system')" title="System theme" aria-label="System theme"> | |
| <i data-lucide="monitor" class="theme-icon" aria-hidden="true"></i> | |
| </button> | |
| <button type="button" class="theme-btn" :class="{ active: theme === 'dark' }" `@click`="setTheme('dark')" title="Dark theme" aria-label="Dark theme"> | |
| <i data-lucide="moon" class="theme-icon" aria-hidden="true"></i> | |
| </button> | |
| </div> | |
| <button type="button" class="theme-toggle-mobile" | |
| `@click`="toggleTheme()" | |
| :title="theme === 'light' ? 'Light theme' : theme === 'dark' ? 'Dark theme' : 'System theme'" | |
| :aria-label="theme === 'light' ? 'Light theme' : theme === 'dark' ? 'Dark theme' : 'System theme'"> |
🧰 Tools
🪛 HTMLHint (1.9.2)
[warning] 50-50: The type attribute must be present on elements.
(button-type-require)
[warning] 53-53: The type attribute must be present on
elements.(button-type-require)
[warning] 56-56: The type attribute must be present on
elements.(button-type-require)
[warning] 60-60: The type attribute must be present on
elements.(button-type-require)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@internal/admin/dashboard/templates/sidebar.html` around lines 50 - 63, The
theme control buttons (elements with class "theme-btn" and "theme-toggle-mobile"
that call setTheme(...) and toggleTheme()) lack explicit button types causing
potential form-submission; add type="button" to each <button> element for the
three theme buttons and the mobile toggle button so they do not act as submit
buttons if placed inside a form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs-openapiwhennodeornpxis missingVerification
dashboard JavaScript unit testsmake test-racehot-path performance guard (alloc/byte thresholds)make lintSummary by CodeRabbit
Documentation
Accessibility
Bug Fixes
Chores