Fix COREMS_DATABASE_URL env var not overriding hardcoded default#30
Open
robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
Open
Fix COREMS_DATABASE_URL env var not overriding hardcoded default#30robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
Conversation
The MolecularFormulaSearchSettings dataclass has a hardcoded url_database default pointing to localhost:5432. The __post_init__ method checks COREMS_DATABASE_URL only when url_database is empty, but the hardcoded default means it's never empty — so the env var from .env (which points to the 'molformdb' compose service) is silently ignored. Move the os.getenv() call to the field default so COREMS_DATABASE_URL is respected at initialization time. The localhost fallback is preserved for non-compose setups. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MolecularFormulaSearchSettings.url_databasefield has a hardcoded default pointing tolocalhost:5432__post_init__method checksCOREMS_DATABASE_URLonly whenurl_databaseis empty, but the hardcoded default means it's never empty — so the env var from.env(which points to themolformdbcompose service) is silently ignoredos.getenv("COREMS_DATABASE_URL", ...)call to the field default so it's respected at initialization time, while preserving thelocalhostfallback for non-compose setupsTest plan
SearchMolecularFormulasconnects to themolformdbservice when usingdocker-compose.ymlwith the provided.envlocalhostfallback still works whenCOREMS_DATABASE_URLis not set🤖 Generated with Claude Code