port v5.6 HelpersClass, Modals, and stub Indicators/Duals JSONs (#458)#463
Merged
Conversation
@AwkJay thank you for your work on this. This fixes a real problem. Thank you also to @Adityakushwaha2006 for catching the issue on windows.
github-actions
Bot
added
the
needs-intake-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #458.
Adds the few files we need to start the v5.6 sync. Two come from upstream as-is. The other two are empty placeholders for config files upstream's code reads but never actually committed — without these the app crashes on first load. Small
.gitignoretweak so the placeholders aren't ignored.Foundation only; the actual wiring happens in the later sub-PRs.