Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dtolnay/rust-toolchain@masterin CI workflows so upstream changes cannot execute arbitrary code in the project's CI.Description
dtolnay/rust-toolchain@masterwith the fixed refdtolnay/rust-toolchain@1.86in.github/workflows/rust.yml.dtolnay/rust-toolchain@masterwith the fixed refdtolnay/rust-toolchain@1.86in.github/workflows/sdk.yaml.toolchain: 1.92.0, components, and additional targets intact so workflow behavior is unchanged.Testing
sed -n '1,200p' .github/workflows/rust.ymlandsed -n '1,220p' .github/workflows/sdk.yaml, which showed the updated action refs and unchanged toolchain settings; these commands succeeded.rg -n "dtolnay/rust-toolchain@" .github/workflows, which returned only the pinned@1.86entries; this check succeeded.git diff -- .github/workflows/rust.yml .github/workflows/sdk.yamlto confirm only the action ref lines were changed; this check succeeded.Codex Task