Merged
Conversation
Member
|
Looks good. I personally don't use it but I appreciate making the dev setup easier to work with. |
DecDuck
previously approved these changes
Mar 29, 2026
Member
|
Lint failed, should be fixable with |
DecDuck
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #375 I had to do some things to setup a working environment. To simplify the working inside of this project I want to propose to provide a devcontainer which containerizes the workspace and makes it easy to make it reproducible. I think this makes it much easier for new people to jump into a project.
I decided to include a postgres instance which automatically runs with the devcontainer - I have no experience with prisma but it looks like you could also use that to spin up instances and switch between them easily by changing the port inside the .env file. But I hope this setup is okay as well.
If this is not okay, please tell me if I can do something to make this work. But if you decide that you don't want to include this, this is of course okay as well. Thanks for your work! 🙏