Skip to content

Fixed screenshotting with RTL #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
truelockmc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed screenshotting with RTL #1295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions app/src/main/kotlin/com/looker/droidify/ui/appDetail/AppDetailFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,12 +513,14 @@ class AppDetailFragment() : ScreenFragment(), AppDetailAdapter.Callbacks {
}

override fun onScreenshotClick(position: Int) {
val isRtl = resources.configuration.layoutDirection == View.LAYOUT_DIRECTION_RTL
if (imageViewer == null) {
val productRepository = products.findSuggested(installed?.installedItem) ?: return
val screenshots = productRepository.first.screenshots.mapNotNull {
if (it.type == Product.Screenshot.Type.VIDEO) null
else it
}
}.let { if (isRtl) it.reversed() else it }
val startPosition = if (isRtl) screenshots.size - 1 - position else position
imageViewer = StfalconImageViewer
.Builder(context, screenshots) { view, current ->
val screenshotUrl = current.url(
Expand All @@ -530,8 +532,15 @@ class AppDetailFragment() : ScreenFragment(), AppDetailAdapter.Callbacks {
allowHardware(false)
}
}
imageViewer?.withStartPosition(startPosition)
} else {
val productRepository = products.findSuggested(installed?.installedItem) ?: return
val screenshotCount = productRepository.first.screenshots.count {
it.type != Product.Screenshot.Type.VIDEO
}
val startPosition = if (isRtl) screenshotCount - 1 - position else position
imageViewer?.withStartPosition(startPosition)
}
imageViewer?.withStartPosition(position)
imageViewer?.show()
}

Expand Down
Loading