Add Resend click tracking domain template#950
Open
cassiozen wants to merge 1 commit intoDomain-Connect:masterfrom
Open
Add Resend click tracking domain template#950cassiozen wants to merge 1 commit intoDomain-Connect:masterfrom
cassiozen wants to merge 1 commit intoDomain-Connect:masterfrom
Conversation
PR Description Check PassedAll required sections are filled in correctly. Details |
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
pawel-kow
requested changes
Apr 6, 2026
| "records": [ | ||
| { | ||
| "type": "CNAME", | ||
| "host": "%trackingSubdomain%", |
Member
There was a problem hiding this comment.
From the description it looks like host parameter shall be used instead of %trackingSubdomain%.
See Rule 8 from README.
pawel-kow
reviewed
Apr 6, 2026
| { | ||
| "type": "CNAME", | ||
| "host": "%trackingSubdomain%", | ||
| "pointsTo": "%cnameTarget%", |
Member
There was a problem hiding this comment.
Is it right to assume, that the pointsTo is always under ".resend.com" domain, so narrow scope like "%cnametarget%.resend.com" is worth consideration?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are introducing the capability of users to choose their own custom
click tracking domain at Resend.
This setup is separate from the domain configurations for sending
and/or receiving emails (whose templates are already available).
Additional Considerations:
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.
syncPubKeyDomainis set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejectedwarnPhishingis not set alongsidesyncPubKeyDomain— the two must not appear togethersyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow"v=spf1 ...") — use theSPFMrecord type insteadtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix (e.g. DMARC) — N/A, no TXT records@ TXT "%foo%") unless necessary — prefer@ TXT "service-foo=%foo%"; if bare, justify in the PR descriptionhostlabel — the non-variable parts are fixed to limit misuse (e.g.%dkimkey%._domainkey, not%dkimhost%); if bare, justify in the PRdescription
hostfield to create a subdomain — use thehostparameter ormultiInstanceinstead%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (e.g. DMARC) — N/A, single CNAME is the core recordOnline Editor test results
Editor test link(s):