-
Notifications
You must be signed in to change notification settings - Fork 504
Add euromail.dev mail template #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lamminpaa
wants to merge
6
commits into
Domain-Connect:master
Choose a base branch
from
lamminpaa:add-euromail-template
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b84380b
Add euromail.dev mail template for transactional email DNS setup
lamminpaa dfe84ad
fix: add txtConflictMatchingMode to DKIM TXT record
lamminpaa bcaef4d
fix: use Prefix txtConflictMatchingMode with v=DKIM1 prefix
lamminpaa f15ad97
fix: mark MX record as essential OnApply
lamminpaa 4df8145
fix: revert MX to essential Always (required for VERP bounce routing)
lamminpaa 98d9d06
Merge branch 'master' into add-euromail-template
pawel-kow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "providerId": "euromail.dev", | ||
| "providerName": "EuroMail", | ||
| "serviceId": "mail", | ||
| "serviceName": "Transactional Email", | ||
| "version": 1, | ||
| "syncPubKeyDomain": "euromail.dev", | ||
| "syncRedirectDomain": "euromail.dev", | ||
| "description": "Configure DKIM signing, SPF authorization, and bounce handling for EuroMail transactional email delivery.", | ||
| "logoUrl": "https://euromail.dev/static/favicon.svg", | ||
| "variableDescription": "subdomain: Sending subdomain prefix (default: em). dkimKey: DKIM public key for email signing.", | ||
| "records": [ | ||
| { | ||
| "type": "TXT", | ||
| "host": "euromail._domainkey.%subdomain%", | ||
| "ttl": 3600, | ||
| "data": "v=DKIM1; k=rsa; p=%dkimKey%", | ||
| "txtConflictMatchingMode": "Prefix", | ||
| "txtConflictMatchingPrefix": "v=DKIM1" | ||
| }, | ||
| { | ||
| "type": "SPFM", | ||
| "host": "%subdomain%", | ||
| "ttl": 3600, | ||
| "spfRules": "include:spf.euromail.dev" | ||
| }, | ||
| { | ||
| "type": "MX", | ||
| "host": "%subdomain%", | ||
| "pointsTo": "bounce.euromail.dev", | ||
| "ttl": 3600, | ||
| "priority": 10 | ||
| } | ||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All host entries have the same %subdomain% suffix. It looks like against Rule 8 where host parameter shall be used instead.
@kerolasa is it worth adding to the linter if all RRs share the same variable as suffix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like this should be an info level message saying something like:
all records use the same %variable% as suffix, consider using host parameter insteadLet me spend a moment making that happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I updated wiki text a bit