Skip to content

Add Nordiccdn.com cdn template#913

Merged
pawel-kow merged 5 commits intoDomain-Connect:masterfrom
Edelskjold:master
Mar 27, 2026
Merged

Add Nordiccdn.com cdn template#913
pawel-kow merged 5 commits intoDomain-Connect:masterfrom
Edelskjold:master

Conversation

@Edelskjold
Copy link
Copy Markdown
Contributor

@Edelskjold Edelskjold commented Mar 27, 2026

Description

Adding Nordiccdn.com template, to allow for easy change of DNS records, to onboard on the service.

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

  • syncPubKeyDomain is set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
  • warnPhishing is not set alongside syncPubKeyDomain — the two must not appear together
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • no TXT record contains SPF content ("v=spf1 ...") — use the SPFM record type instead
  • txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC)
  • no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary — prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description
  • no bare variable is used as the full host label — the non-variable parts are fixed to limit misuse (e.g. %dkimkey%._domainkey, not %dkimhost%); if bare, justify in the PR description
  • no variable is used in the host field to create a subdomain — use the host parameter or multiInstance instead
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC)

Online Editor test results

Editor test link(s):

Test nordiccdn.com/cdn-setup example.com/1.1.1.1

@github-actions github-actions bot added the Test links missing No test links from Online Editor provided label Mar 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

JSON Filename Check Passed

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

JSON Schema Validation Passed

@github-actions
Copy link
Copy Markdown

Linter OK

nordiccdn.com.cdn-setup.json

Level Code Note

@Edelskjold
Copy link
Copy Markdown
Contributor Author

@pawel-kow sorry to disturb you, I can see you are actively approving PR. but it seems like i have a problem with the test tool, that i should supply a link to according to the PR documentation. However it seems like the test tool doesnt allow APEXCNAME?
I have done the exact same record as in: #362 and that template cant be verified either using the tool.

@pawel-kow
Copy link
Copy Markdown
Member

Yes, this is not standard therefore not yet implemented.
I assume you are sure you want to use APEXCNAME .
Just this week a provider changed away from it because of non standard and poor support with providers

@Edelskjold
Copy link
Copy Markdown
Contributor Author

Hi there, yes for now we want to use it, as Cloudflare which we recommend do support it. But we know the Apexcname is not supported by many providers.

@pawel-kow
Copy link
Copy Markdown
Member

Ok, I'm lost.
This PR from other provider is actually changing back because of CF.

#905

@kerolasa how is it?

@Edelskjold
Copy link
Copy Markdown
Contributor Author

Ok thats wierd... I had a discussion with one at CF (cant disclose, not official discussion) that said this was the way.
But I see the point raised in #905 , so how would we go about the change, as the @ for CNAME would imply using hostRequired => true, but we want the template to be used on the root domain.

@pawel-kow
Copy link
Copy Markdown
Member

See the comment in #905.
CF allows you to apply such template on apex even with host required

@github-actions github-actions bot added hostRequired hostRequired is set and removed Test links missing No test links from Online Editor provided labels Mar 27, 2026
@github-actions
Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked
  OK  Online Editor test results: 1 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

@Edelskjold
Copy link
Copy Markdown
Contributor Author

@pawel-kow I see, I have now changed the file, and updated the PR description, thank you so much for your help.

@pawel-kow pawel-kow added this pull request to the merge queue Mar 27, 2026
Merged via the queue into Domain-Connect:master with commit 2ee99f8 Mar 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hostRequired hostRequired is set

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants