GetHERD PR

[mlfrancis123]

Description

Type of change

Please mark options that are relevant.

• New template
• Bug fix (non-breaking change which fixes an issue in the template)
• New feature (non-breaking change which adds functionality to the template)
• Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

• Template functionality checked using Online Editor
• Template file name follows the pattern <providerId>.<serviceId>.json
• resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

• syncPubKeyDomain is set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
• warnPhishing is not set alongside syncPubKeyDomain — the two must not appear together
• syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
• no TXT record contains SPF content ("v=spf1 ...") — use the SPFM record type instead
• txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC)
• no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary — prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description
• no variable is used in the host field to create a subdomain — use the host parameter or multiInstance instead
• %host% does not appear explicitly in any host attribute
• essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC)

Online Editor test results

Editor test link(s):

[github-actions]

✅ JSON Filename Check Passed

[github-actions]

✅ JSON Schema Validation Passed

[github-actions]

Linter OK

cms.getherd.ai.site-hosting.json

Level	Code	Note
info	DCTL1029	template does not have syncPubKeyDomain

[github-actions]

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details

  OK  Checklist of common problems: 9/9 checkboxes ticked

Labels to add: PR description incomplete, Test links missing
Labels to remove: Checklist of common problems not complete

PR description check FAILED:
  FAIL  'Type of change': no checkboxes are ticked
  FAIL  'How Has This Been Tested?': 3/3 checkboxes are not ticked
  FAIL  'Online Editor test results': no valid editor test link found
  FAIL  Template coverage: cms.getherd.ai.site-hosting.json: no editor test link found (expected template id 'cms.getherd.ai.site-hosting')

[github-actions]

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details

  OK  Checklist of common problems: 9/9 checkboxes ticked

Labels to add: PR description incomplete, Test links missing
Labels to remove: Checklist of common problems not complete

PR description check FAILED:
  FAIL  'Type of change': no checkboxes are ticked
  FAIL  'How Has This Been Tested?': 3/3 checkboxes are not ticked
  FAIL  'Online Editor test results': no valid editor test link found
  FAIL  Template coverage: cms.getherd.ai.site-hosting.json: no editor test link found (expected template id 'cms.getherd.ai.site-hosting')

[github-actions]

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details

  OK  Type of change: 1/4 checkboxes ticked
  OK  Checklist of common problems: 9/9 checkboxes ticked

Labels to add: PR description incomplete, Test links missing
Labels to remove: Checklist of common problems not complete

PR description check FAILED:
  FAIL  'How Has This Been Tested?': 3/3 checkboxes are not ticked
  FAIL  'Online Editor test results': no valid editor test link found
  FAIL  Template coverage: cms.getherd.ai.site-hosting.json: no editor test link found (expected template id 'cms.getherd.ai.site-hosting')

[github-actions]

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details

  OK  Type of change: 1/4 checkboxes ticked
  OK  Checklist of common problems: 9/9 checkboxes ticked

Labels to add: PR description incomplete, Test links missing
Labels to remove: Checklist of common problems not complete

PR description check FAILED:
  FAIL  'How Has This Been Tested?': 2/3 checkboxes are not ticked
  FAIL  'Online Editor test results': no valid editor test link found
  FAIL  Template coverage: cms.getherd.ai.site-hosting.json: no editor test link found (expected template id 'cms.getherd.ai.site-hosting')