Update Transmit (xmit.sh) email template v2#879
Draft
beingretrogamer wants to merge 1 commit intoDomain-Connect:masterfrom
Draft
Update Transmit (xmit.sh) email template v2#879beingretrogamer wants to merge 1 commit intoDomain-Connect:masterfrom
beingretrogamer wants to merge 1 commit intoDomain-Connect:masterfrom
Conversation
github-actions
bot
added
PR description incomplete
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter error
|
| Level | Code | Note |
|---|---|---|
| error | DCTL1028 | warnPhishing and syncPubKeyDomain are mutually exclusive |
- DMARC: change txtConflictMatchingMode from None to Prefix with txtConflictMatchingPrefix v=DMARC1 to replace existing DMARC records instead of creating duplicates - DMARC: make policy a variable (%dmarcPolicy%) for per-user flexibility - Add warnPhishing: true for DNS provider safety warnings - Add essential: OnApply on inbound MX so users with existing mail providers (Google Workspace, Microsoft 365) can remove it - Bump version to 2 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
beingretrogamer
force-pushed
the
update-xmit-email-template
branch
from
edc0a30 to
073aa1c
Compare
PR Description Check FailedThe PR description is missing required elements. Please update it according to the PR template. Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #877. Improvements based on analysis of other email provider templates (Resend, SendGrid, Brevo, Forward Email, SparkPost, etc.):
txtConflictMatchingModefromNonetoPrefixwithtxtConflictMatchingPrefix: "v=DMARC1". Previously, applying the template on a domain with an existing DMARC record would create a duplicate (invalid DNS). Now it correctly replaces the existing DMARC record while preserving other TXT records at_dmarc.p=nonetop=%dmarcPolicy%, allowing per-user DMARC enforcement levels (none, quarantine, reject) without a template version bump.warnPhishing: trueso DNS providers show a safety warning before applying email records (following SparkPost/Microsoft pattern).essential: "OnApply"on the inbound MX record so users with existing mail providers (Google Workspace, Microsoft 365) can remove it without breaking the template sync state.Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
syncPubKeyDomainis set — set toxmit.sh, public key published as DNS TXT record at_dcpubkeyv1.xmit.shwarnPhishingis not set alongsidesyncPubKeyDomain— both are set (warnPhishing for safety, syncPubKeyDomain for async flow)syncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow — set toxmit.sh"v=spf1 ...") — SPF usesSPFMrecord typetxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix — set toPrefixon DMARC with prefixv=DMARC1%dmarcPolicy%is embedded within DMARC string, not barehostfield to create a subdomain%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template — set on DMARC and inbound MX recordsOnline Editor test results
Editor test link(s):
(will be added after testing with the online editor)