Add Meteorack hosting Domain Connect templates#852
Open
niknot wants to merge 1 commit intoDomain-Connect:masterfrom
Open
Add Meteorack hosting Domain Connect templates#852niknot wants to merge 1 commit intoDomain-Connect:masterfrom
niknot wants to merge 1 commit intoDomain-Connect:masterfrom
Conversation
|
✅ JSON Filename Check Passed |
PR Description Check FailedThe PR description is missing required elements. Please update it according to the PR template. Details |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
meteorack.app.hosting-subdomain-v1.json
| Level | Code | Note |
|---|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add two new Meteorack hosting templates for Google-hosted tenant domains:
meteorack.app.hosting-apex-v1.jsonmeteorack.app.hosting-subdomain-v1.jsonThese templates are used by Meteorack to connect apex/root domains and subdomains to tenant sites hosted on the Meteorack Google tenant edge.
Notes:
syncPubKeyDomainis set and live at_dcpubkeyv1.meteorack.appsyncRedirectDomainis set toapp.meteorack.comA,AAAA, andCNAMEtargets because the target values are runtime infrastructure values provided by Meteorack during the sync flow%VERIFY_HOST%is intentionally used inhostonly for the Google-managed verification record; it is not used to emulate the Domain Connecthostparameter for the customer-facing domain labelType of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.
syncPubKeyDomainis set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejectedwarnPhishingis not set alongsidesyncPubKeyDomain— the two must not appear togethersyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow"v=spf1 ...") — use theSPFMrecord type insteadtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix (e.g. DMARC)@ TXT "%foo%") unless necessary — prefer@ TXT "service-foo=%foo%"; if bare, justify in the PR descriptionhostfield to create a subdomain — use thehostparameter ormultiInstanceinstead%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (e.g. DMARC)Online Editor test results
Editor test link(s):