Skip to content

Fix PR Details diff rendering and reduce initial load stalls#82

Open
DomDom3333 wants to merge 1 commit intomainfrom
codex/fix-pr-details-view-and-diffviewer-issues
Open

Fix PR Details diff rendering and reduce initial load stalls#82
DomDom3333 wants to merge 1 commit intomainfrom
codex/fix-pr-details-view-and-diffviewer-issues

Conversation

@DomDom3333
Copy link
Owner

Summary

  • fixed diff content loading cancellation so opening one file no longer cancels another file’s in-flight load
  • fixed DiffContainer discovery in PullRequestDetailsWindow by targeting the named container instead of the first descendant Border
  • removed unused per-load cancellation state from PullRequestDetailsWindowViewModel

Root cause

  1. Each expand action called BeginDiffContentLoad(), which canceled the previous token globally. During expand-all or fast clicks this canceled active loads, so many diff viewers never received content.
  2. CreateDiffViewerAsync used expander.FindDescendantOfType<Border>(), which can return a header border instead of the actual content host, so the DiffViewer was sometimes injected into the wrong place.

Validation

  • dotnet build AzurePrOps/AzurePrOps.sln -c Release
  • dotnet build AzurePrOps/AzurePrOps.sln -c Release --no-restore
  • dotnet test AzurePrOps/AzurePrOps.Tests/AzurePrOps.Tests.csproj -c Release --no-build

Build/test passed; only pre-existing warnings remain.


Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant