Fix PR Details diff rendering and reduce initial load stalls#82
Open
DomDom3333 wants to merge 1 commit intomainfrom
Open
Fix PR Details diff rendering and reduce initial load stalls#82DomDom3333 wants to merge 1 commit intomainfrom
DomDom3333 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiffContainerdiscovery inPullRequestDetailsWindowby targeting the named container instead of the first descendantBorderPullRequestDetailsWindowViewModelRoot cause
BeginDiffContentLoad(), which canceled the previous token globally. During expand-all or fast clicks this canceled active loads, so many diff viewers never received content.CreateDiffViewerAsyncusedexpander.FindDescendantOfType<Border>(), which can return a header border instead of the actual content host, so theDiffViewerwas sometimes injected into the wrong place.Validation
dotnet build AzurePrOps/AzurePrOps.sln -c Releasedotnet build AzurePrOps/AzurePrOps.sln -c Release --no-restoredotnet test AzurePrOps/AzurePrOps.Tests/AzurePrOps.Tests.csproj -c Release --no-buildBuild/test passed; only pre-existing warnings remain.
Codex Task