feat: allow selecting stored registries for Docker image pull#3678
Open
AceRRR10 wants to merge 2 commits intoDokploy:canaryfrom
Open
feat: allow selecting stored registries for Docker image pull#3678AceRRR10 wants to merge 2 commits intoDokploy:canaryfrom
AceRRR10 wants to merge 2 commits intoDokploy:canaryfrom
Conversation
Add a registry dropdown to the Docker provider form, allowing users to select a previously saved registry instead of manually entering credentials. When a stored registry is selected, its credentials are used for docker login and the registry URL/username are prepended to the image name for pulling. Inline credential fields are hidden when a registry is selected, preserving backward compatibility.
Reverts the automatic prefixing of registry URL/username to the docker image name, aligning with the existing behavior where users provide the full image reference (e.g. ghcr.io/user/image:latest) in the Docker Image field. The stored registry is still used for docker login credentials only, consistent with how inline credentials worked before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
When using the "Docker" source type for an application, users currently must manually enter
username,password, andregistryUrlfor every application. However, Dokploy already has a registry management system (Settings > Registry) where users store registry credentials. This PR adds a dropdown to select a stored registry when configuring a Docker image pull, avoiding redundant credential entry.Changes:
registryIdon the application and clears inline credentials when a registry is selected (and vice versa).buildRemoteDockerandgetAuthConfignow use the linked registry's credentials when available, falling back to inline credentials for backward compatibility.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
N/A
Screenshots (if applicable)