Open
Conversation
added 3 commits
March 17, 2021 13:35
HW6(Async-RegExp)/HW6_Trupkina.js
Outdated
Comment on lines
+6
to
+7
| if (email === null) return undefined;//i catch cancellation | ||
| else if (regexp_email.test(email) === true) return alert('This is your Email:\n' + email); |
There was a problem hiding this comment.
pls, try do not use syntax like that
for readable better write
if (...) { ... } else if (...) { ... }
HW6(Async-RegExp)/HW6_Trupkina.js
Outdated
|
|
||
| function validEmail() { | ||
| //Set the default value | ||
| let email = prompt('Type correctly email please', `example@gmail.com`); |
There was a problem hiding this comment.
better write pure function
HW6(Async-RegExp)/HW6_Trupkina.js
Outdated
| const regexp_email = /^([\w\.+-]{3,})+@[A-z0-9-]{3,10}\.[A-z]{2,6}$/;//we can't use \w in domen name and sub name | ||
| if (email === null) return undefined;//i catch cancellation | ||
| else if (regexp_email.test(email) === true) return alert('This is your Email:\n' + email); | ||
| return validEmail(); |
There was a problem hiding this comment.
Why do you need the function to return itself?
HW6(Async-RegExp)/HW6_Trupkina.js
Outdated
Comment on lines
+5
to
+7
| const regexp_email = /^([\w\.+-]{3,})+@[A-z0-9-]{3,10}\.[A-z]{2,6}$/;//we can't use \w in domen name and sub name | ||
| if (email === null) return undefined;//i catch cancellation | ||
| else if (regexp_email.test(email) === true) return alert('This is your Email:\n' + email); |
There was a problem hiding this comment.
I do not understand the logic of this function, let's discuss it by voice
HW6(Async-RegExp)/HW6_Trupkina.js
Outdated
Comment on lines
+12
to
+17
| //Set the default value with Math.random() if user doesn't want to come up with password | ||
| let password = prompt('Type your password please', Math.floor(Math.random() * Math.floor(999999)) + 'Add!t'); | ||
| const regexp_pass = /^.*(?=.{8,})(?=.+[A-Z])(?=.+[a-z])(?=.*[!@#$%^&*?+=-]).*$/; | ||
| if (password === null) return undefined;//i catch cancellation | ||
| else if (regexp_pass.test(password) === true) return alert('This is your password:\n' + password); | ||
| return validPassword(); |
There was a problem hiding this comment.
the same as the previous function
HW6(Async-RegExp)/HW6_Trupkina.js
Outdated
| 'exa23@44m.p-le@Flora-mix.ru' //false - for all ()!@#$%^&*= | ||
| ]; | ||
| console.log(validEmail(email)); | ||
| function validEmail(mail) { |
Owner
There was a problem hiding this comment.
function name should be a verb.
and this still not reading the function
HW6(Async-RegExp)/HW6_Trupkina.js
Outdated
| function validEmail(mail) { | ||
| const regexp_email = /^([\w\.+-]{3,})+@[A-z0-9-]{3,10}\.[A-z]{2,6}$/;//we can't use \w in domen name and sub name because '_' included | ||
| for (const iterator of mail) { | ||
| //console.log(`${iterator}: ${regexp_email.test(iterator) === true}`);//can be write shorter |
There was a problem hiding this comment.
don't leave dead code in PR
HW6(Async-RegExp)/HW6_Trupkina.js
Outdated
| const regexp_email = /^([\w\.+-]{3,})+@[A-z0-9-]{3,10}\.[A-z]{2,6}$/;//we can't use \w in domen name and sub name because '_' included | ||
| for (const iterator of mail) { | ||
| //console.log(`${iterator}: ${regexp_email.test(iterator) === true}`);//can be write shorter | ||
| if (regexp_email.test(iterator) === true) { |
There was a problem hiding this comment.
unnecessary checking. you can just leave
if (regexp_email.test(iterator))
HW6(Async-RegExp)/HW6_Trupkina.js
Outdated
| '############' //false | ||
| ]; | ||
| console.log(validPassword(password)); | ||
| function validPassword(pass) { |
There was a problem hiding this comment.
function name should be a verb.
HW6(Async-RegExp)/HW6_Trupkina.js
Outdated
| Large and small letters must be present, the password is at least 8 characters long */ | ||
| const regexp_pass = /^.*(?=.{8,})(?=.+[A-Z])(?=.+[a-z])(?=.*[!@#$%^&*?+=-]).*$/; | ||
| for (const iterator of pass) { | ||
| if (regexp_pass.test(iterator) === true) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.