Detect es6 classes via toString starting with word 'class'#41
Merged
Conversation
wiwichips
reviewed
Mar 13, 2026
wiwichips
requested changes
Mar 13, 2026
wiwichips
reviewed
Mar 13, 2026
add space to es6 class check Co-authored-by: Will Pringle <will@distributive.network>
Collaborator
|
LGTM |
Collaborator
|
still LGTM 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dcp-client, the
BankAccountKeystoreclass extends theKeystoreclass, but doesn't add any own properties to the class prototype. Thus, it was detected as a function, not a class originally. This change can fairly reliably detect all es6 classes (but will not detect any es5 classes). Run both detection methods for improved detection overall.