ENG-1611 Add provisional status to imported relation schemas#948
Open
trangdoan982 wants to merge 4 commits intomainfrom
Open
ENG-1611 Add provisional status to imported relation schemas#948trangdoan982 wants to merge 4 commits intomainfrom
trangdoan982 wants to merge 4 commits intomainfrom
Conversation
Mark newly imported relation types and triplets as provisional so they don't appear in creation UIs until explicitly accepted by the user. - Add ImportStatus type and status? field to DiscourseRelationType and DiscourseRelation - Add isAcceptedSchema / isProvisionalSchema helpers (imported + no status = provisional) - Set status: "provisional" on all newly imported relation types and triplets - Fix provisional: true on imported relation instances (was incorrectly false) - Settings UI: show Provisional badge + Accept/Delete buttons for provisional imported schemas - Accepting a triplet cascades to also accept its relation type - Filter provisional schemas from all creation panels (canvas tool, RelationshipSection, RelationPanel) - Guard publishNewRelation and sync against provisional schemas - Prevent status from leaking into literal_content.source_data in conceptConversion Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- tentative: false = unreviewed (not tentative: true); fix importRelations, publishNode guard, and syncDgNodesToSupabase filter accordingly - Add isAcceptedSchema to compatible node types useEffect in RelationshipSection Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
mdroidian
approved these changes
Apr 14, 2026
Member
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
What happens if you delete a schema and then re-import or sync? Does it re-import the deleted schema? If so, this would be a confusing UX.
Member
Author
|
yes it will. but I think we haven't decided on what the mechanism for deleting an imported schema and reimporting them is. Team decided to table this decision is the last I've got. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/8d9ac02487f74b54ac4a06893ca61ab5
Summary
provisionaland hidden from all creation UIs until the user explicitly accepts themImportStatustype andstatus?field toDiscourseRelationTypeandDiscourseRelation; backward-compatible (imported schemas with nostatusfield are treated as provisional)publishNewRelationand the Supabase sync from sending provisional schemasTest plan
upsert_conceptspayloadpublishNewRelationreturns false for provisional triple/type/instancestatusfield treated as provisional (not accepted)🤖 Generated with Claude Code