fix: restore ZMQ ipc:// Unix domain socket support#387
Open
JohnnyLawDGB wants to merge 1 commit intoDigiByte-Core:feature/digidollar-v1from
Open
fix: restore ZMQ ipc:// Unix domain socket support#387JohnnyLawDGB wants to merge 1 commit intoDigiByte-Core:feature/digidollar-v1from
JohnnyLawDGB wants to merge 1 commit intoDigiByte-Core:feature/digidollar-v1from
Conversation
Port validation added during the Bitcoin Core v26.2 merge rejects ipc:// addresses because they use filesystem paths, not host:port format. This breaks users who rely on Unix domain sockets for ZMQ notifications (e.g. zmqpubhashblock=ipc:///tmp/dgb.hashblock), which worked in DigiByte v8.22.2. Split the validation loop so ZMQ options skip port validation for ipc:// addresses while TCP-only options (-rpcbind, -proxy, etc.) retain strict validation. libzmq natively handles ipc:// endpoints. Fixes: DigiByte-Core#340 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ipc://) support that broke in v8.26 during the Bitcoin Core v26.2 mergeipc://addresses while TCP-only options (-rpcbind,-proxy, etc.) retain strict validationdoc/zmq.md:88)Background
Port validation added in the v26.2 merge rejects
ipc://addresses becauseSplitHostPort()expectshost:portformat. Unix domain sockets use filesystem paths (ipc:///tmp/dgb.hashblock), not ports. This causes nodes configured withzmqpubhashblock=ipc:///tmp/dgb.hashblockto crash on startup with "Invalid port specified".Bitcoin Core fixed this in v28.0 (PRs #27375, #27679) using a
unix:prefix with internalipc://conversion. This PR takes a simpler approach — directly allowingipc://— since DigiByte v8.22.2 already usedipc://andlibzmqnatively supports it.Targeting
feature/digidollar-v1for testnet validation, intended for inclusion in v9.26 mainnet release.Fixes #340
Test plan
zmqpubhashblock=ipc:///tmp/dgb.hashblockno longer crashes on startupzmqpubhashblock=tcp://127.0.0.1:212024still works (TCP validation intact)zmqpubhashblock=tcp://badhost) are still rejected-rpcbind,-proxy) still require valid ports🤖 Generated with Claude Code