Simplify config file params#1699
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1699 +/- ##
==========================================
- Coverage 93.03% 93.02% -0.02%
==========================================
Files 165 164 -1
Lines 8928 8912 -16
==========================================
- Hits 8306 8290 -16
Misses 622 622
🚀 New features to boost your workflow:
|
rtuck99
force-pushed
the
configure_config_server
branch
from
abea743 to
152627f
Compare
… tests, system tests still broken
rtuck99
force-pushed
the
simplify_config_file_params
branch
2 times, most recently
from
d44597a to
2b017ab
Compare
jacob720
approved these changes
May 15, 2026
Contributor
jacob720
left a comment
jacob720
left a comment
There was a problem hiding this comment.
Looks good, just a question
| log_debug("nexgen logger added to nexus logger") | ||
|
|
||
|
|
||
| def create_config_client() -> ConfigClient: |
Contributor
There was a problem hiding this comment.
Do we need this because callbacks run in a seperate process and we can't just use get_config_client from dodal?
Contributor
Author
There was a problem hiding this comment.
Yes, in the callback process, we don't have any devices or fixtures as the beamline module is not loaded, so we need some way to initialise the config client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies setup of various config file configuration points by removing redundant points of configuration, so that it is easier to fix the system tests.
Requires:
This introduces some potentially breaking changes in the parameter model but I don't believe these parameters are actually being used anywhere and are left at their defaults.
Breaking changes:
det_dist_to_beam_converter_pathandinsertion_prefixfromWithVisitOther changes:
load_panda_from_yaml()in favour of the identical dodal functionmx_bluesky.hyperion.parameters.constantsand support forHYPERION_TEST_MODEenv varI03ConstantsDetectorParamConstants.BEAM_XY_LUT_PATHalways use the production value instead of depending on TEST_MODEInstructions to reviewer on how to test:
Checks for reviewer