Skip to content

Add ispyb integration for vmxm grid scans#1639

Merged
olliesilvester merged 8 commits into
add_vmxm_gridscan_planfrom
ispyb_integration_vmxm_grid_scan
Mar 3, 2026
Merged

Add ispyb integration for vmxm grid scans#1639
olliesilvester merged 8 commits into
add_vmxm_gridscan_planfrom
ispyb_integration_vmxm_grid_scan

Conversation

@olliesilvester
Copy link
Copy Markdown
Contributor

@olliesilvester olliesilvester commented Feb 23, 2026

Requires #1636

Link to dodal PR (if required): #XXX
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 63.07054% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.00%. Comparing base (b817bd7) to head (9b53f1d).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           add_vmxm_gridscan_plan    #1639      +/-   ##
==========================================================
- Coverage                   92.82%   92.00%   -0.83%     
==========================================================
  Files                         156      161       +5     
  Lines                        8757     8980     +223     
==========================================================
+ Hits                         8129     8262     +133     
- Misses                        628      718      +90     
Components Coverage Δ
i24 SSX 78.60% <ø> (ø)
hyperion 98.22% <100.00%> (+<0.01%) ⬆️
other 96.01% <62.12%> (-2.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olliesilvester
Copy link
Copy Markdown
Contributor Author

Needs unit tests but otherwise ready

@olliesilvester olliesilvester changed the title Add ispyb integration for vmxm grid scans [wip] Add ispyb integration for vmxm grid scans Mar 2, 2026
@olliesilvester olliesilvester marked this pull request as ready for review March 2, 2026 15:26
@olliesilvester olliesilvester requested a review from a team as a code owner March 2, 2026 15:26
@olliesilvester olliesilvester force-pushed the add_vmxm_gridscan_plan branch from b817bd7 to 22ec8d2 Compare March 2, 2026 15:42
@olliesilvester olliesilvester force-pushed the ispyb_integration_vmxm_grid_scan branch from 4a1930d to 78dac28 Compare March 2, 2026 15:43
@olliesilvester olliesilvester merged commit 78dac28 into add_vmxm_gridscan_plan Mar 3, 2026
8 of 12 checks passed
@olliesilvester olliesilvester deleted the ispyb_integration_vmxm_grid_scan branch March 3, 2026 09:01
@olliesilvester olliesilvester restored the ispyb_integration_vmxm_grid_scan branch March 3, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant