Prevent notebook execution from running twice#202
Open
jessicavers wants to merge 1 commit into
Open
Conversation
jessicavers
force-pushed
the
update-workflows
branch
from
936be32 to
113a50a
Compare
daurer
requested changes
May 15, 2026
Collaborator
daurer
left a comment
daurer
left a comment
There was a problem hiding this comment.
Looks good but I think there is more potential to further reduce duplicated execution
Comment on lines
77
to
78
| python -m jupyter nbconvert /tmp/notebook-parametrized.ipynb --to notebook --execute --allow-errors --output align-notebook --output-dir "{{`{{ inputs.parameters.outpath }}`}}" | ||
| python -m jupyter nbconvert "{{`{{ inputs.parameters.outpath }}`}}/align-notebook.ipynb" --to html --output align-output --output-dir "{{`{{ inputs.parameters.outpath }}`}}" |
Collaborator
There was a problem hiding this comment.
I think these can be combined into one execution with --to-html and --execute similar to how it works for the XRF tomography template. I think it is basically the second command with an extra --execute...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.