Remove halving of --max-memory value#717
Merged
Merged
Conversation
This is a leftover from when there was only GPU memory estimation (the max slices estimation for GPU methods) in the framework and no CPU memory estimation (the dataset store backing calculation, choosing between RAM or an hdf5 file). The max slices estimators of GPU methods all take into account the output as well as the input needing to be stored in GPU memory, so there's no need to halve the `--max-memory` value in order to account for the size of the input and output of a section - the GPU method memory estimators already account for this. The CPU memory estimation in the dataset store backing calculator accounts for the output chunk that will be written by a section in addition to the input chunk being read by a section, so in the CPU memory case there's also no need to do the halving of the `--max-memory` value.
yousefmoazzam
force-pushed
the
max-memory-halving
branch
from
cb3b646 to
b5fee64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IMGDA-841
Checklist
user-release-notelabel in order to include this PR in the "NotableChanges for Users" section in release notes