Open
Conversation
Open
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
In general, looks okay but I couldn't fully test it because of:
- When running
uvicorn main:app --reload, got
raise RuntimeError(f"Directory '{directory}' does not exist")
RuntimeError: Directory 'static' does not exist
- "Unable to connect" error from http://127.0.0.1:8000/
Seen these both as dev and in container.
There was a problem hiding this comment.
This file and the react.svg can be removed
| pip install -e . | ||
|
|
||
| cd calibration_ui | ||
| module load node |
There was a problem hiding this comment.
Unfortunately at the moment the default version of node on dls workstation is 21.#.# which is unsupported by some of the packages being installed. To avoid issues, I would change this to node/latest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14
Apologies for the massive diff but I think most of it is VITE + React boilerplate
To Test