Skip to content

GridCommands: implement paging, filter, group commands#33457

Open
anna-shakhova wants to merge 5 commits intoDevExpress:26_1from
anna-shakhova:26_1__commands_misc
Open

GridCommands: implement paging, filter, group commands#33457
anna-shakhova wants to merge 5 commits intoDevExpress:26_1from
anna-shakhova:26_1__commands_misc

Conversation

@anna-shakhova
Copy link
Copy Markdown
Contributor

No description provided.

@anna-shakhova anna-shakhova self-assigned this Apr 29, 2026
@anna-shakhova anna-shakhova changed the title GridCommands: add paging, filter, group commands GridCommands: implement paging, filter, group commands Apr 29, 2026
@anna-shakhova anna-shakhova force-pushed the 26_1__commands_misc branch from b24ef3a to a1ca750 Compare May 5, 2026 12:08
@anna-shakhova anna-shakhova marked this pull request as ready for review May 5, 2026 12:09
Copilot AI review requested due to automatic review settings May 5, 2026 12:09
@anna-shakhova anna-shakhova requested a review from a team as a code owner May 5, 2026 12:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the internal Grid AI Assistant command surface by adding paging, filtering/searching, and DataGrid-specific grouping commands, along with a small typing refactor to infer executor argument types directly from each command’s Zod schema.

Changes:

  • Refined GridCommand typing so command executor args are inferred from the Zod schema (including treating empty-object schemas as no-arg commands).
  • Added new grid-core AI assistant commands: paging (paging, pageSize, pageIndex) and filtering (filterValue, clearFilter, searching), with Jest coverage.
  • Added DataGrid AI assistant module entrypoint and DataGrid-specific grouping commands (grouping, clearGrouping) with Jest coverage.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/types.ts Refactors GridCommand to infer executor argument types from the Zod schema (and collapse empty schemas to no-arg executors).
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/sorting.ts Migrates sorting commands to defineGridCommand and updates the command description.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/defineGridCommand.ts Adds a typed helper to preserve schema-based inference when defining commands.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/paging.ts Introduces paging-related commands (paging, pageSize, pageIndex).
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/filtering.ts Introduces filtering/search commands (filterValue, clearFilter, searching) including a recursive filter-expression schema.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/sorting.test.ts Small adjustment in an error-throwing test case.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/paging.test.ts Adds Jest coverage for paging commands (schema, execution, default messages).
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/filtering.test.ts Adds Jest coverage for filtering/search commands (schema, execution, default messages).
packages/devextreme/js/__internal/grids/data_grid/m_widget.ts Switches DataGrid to import the new AI assistant module entrypoint.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/ai_assistant.ts Adds the DataGrid aiAssistant module registration (controllers/views + default options).
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/grouping.ts Adds DataGrid-specific grouping commands (grouping, clearGrouping).
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/tests/grouping.test.ts Adds Jest coverage for DataGrid grouping commands (schema, execution, default messages).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants