TreeView: fix KBN navigation (expand/collapse) on disabled nodes#32683
Merged
pharret31 merged 3 commits intoDevExpress:26_1from Feb 25, 2026
Merged
Conversation
EugeniyKiyashko
previously approved these changes
Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes TreeView keyboard navigation so disabled nodes can be expanded/collapsed via Left/Right arrows, aligning behavior with expected KBN interactions in the widget.
Changes:
- Adjust TreeViewBase focus movement logic to no longer skip disabled nodes when expanding/collapsing via keyboard.
- Add QUnit coverage to verify expand/collapse and related events (
onItemExpanded/onItemCollapsed) work for disabled nodes. - Update an existing disabled-parent focus regression test to use Left/Right navigation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/treeViewParts/keyboardNavigation.js | Adds/updates keyboard-navigation tests covering disabled-node expand/collapse and event firing. |
| packages/devextreme/js/__internal/ui/tree_view/tree_view.base.ts | Removes “skip disabled nodes” helpers and updates Left/Right focus/expand/collapse behavior accordingly. |
packages/devextreme/testing/tests/DevExpress.ui.widgets/treeViewParts/keyboardNavigation.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/treeViewParts/keyboardNavigation.js
Outdated
Show resolved
Hide resolved
EugeniyKiyashko
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.