Merged
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success653 tests passing in 65 suites. Report generated by 🧪jest coverage report action from c72beee |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #187 by making XML comment serialization stable across repeated identity transformations, and exposes xmlTransformedText through the public package entrypoint for easier reuse.
Changes:
- Adjusted transformed XML serialization to avoid inserting extra spaces around comment content.
- Exported
xmlTransformedTextfromsrc/index.ts. - Added/updated tests to cover comment round-tripping and transformed serialization behavior.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/xslt/issue-187.test.ts | New regression test to ensure repeated identity transforms do not mutate comment text. |
| tests/xml/xml.test.tsx | Adds a unit test ensuring transformed serialization preserves comment boundaries. |
| src/index.ts | Re-exports xmlTransformedText from the package root entrypoint. |
| src/dom/xml-functions.ts | Changes comment node serialization to remove injected boundary spaces. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #187