Skip to content

Issue 187 Requests#188

Merged
leonelsanchesdasilva merged 3 commits intomainfrom
issue-187
Mar 22, 2026
Merged

Issue 187 Requests#188
leonelsanchesdasilva merged 3 commits intomainfrom
issue-187

Conversation

@leonelsanchesdasilva
Copy link
Copy Markdown
Collaborator

Resolves #187

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 22, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.16% (+0.12% 🔼)
3351/4233
🟡 Branches
69.08% (+0.11% 🔼)
1968/2849
🟡 Functions
72.03% (-0.13% 🔻)
394/547
🟡 Lines
79.31% (+0.12% 🔼)
3208/4045
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 index.ts 100% 100%
22.22% (-2.78% 🔻)
100%

Test suite run success

653 tests passing in 65 suites.

Report generated by 🧪jest coverage report action from c72beee

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Issue #187 by making XML comment serialization stable across repeated identity transformations, and exposes xmlTransformedText through the public package entrypoint for easier reuse.

Changes:

  • Adjusted transformed XML serialization to avoid inserting extra spaces around comment content.
  • Exported xmlTransformedText from src/index.ts.
  • Added/updated tests to cover comment round-tripping and transformed serialization behavior.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/xslt/issue-187.test.ts New regression test to ensure repeated identity transforms do not mutate comment text.
tests/xml/xml.test.tsx Adds a unit test ensuring transformed serialization preserves comment boundaries.
src/index.ts Re-exports xmlTransformedText from the package root entrypoint.
src/dom/xml-functions.ts Changes comment node serialization to remove injected boundary spaces.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leonelsanchesdasilva leonelsanchesdasilva merged commit 729e4c5 into main Mar 22, 2026
3 checks passed
@leonelsanchesdasilva leonelsanchesdasilva deleted the issue-187 branch March 22, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Identity transformation is adding spaces to comments

2 participants