fix: show error modal when private DNS startup fails#231
Merged
funa-tk merged 1 commit intoDeNA:masterfrom Mar 2, 2026
Merged
Conversation
toku-sa-n
force-pushed
the
fix/private-dns-start-error-modal
branch
from
986c988 to
61c316d
Compare
funa-tk
reviewed
Mar 1, 2026
Show an error modal and roll back UI state when private DNS start or restart fails, with Japanese i18n text and dialog parenting to the private DNS panel for multi-display environments. Made-with: Cursor
toku-sa-n
force-pushed
the
fix/private-dns-start-error-modal
branch
from
61c316d to
4eaceaf
Compare
Contributor
|
LGTMです |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
プライベートDNSサーバの起動に失敗した際に、エラーメッセージを表示するようにしました。