Open
Conversation
taka2233
force-pushed
the
feat/split-history-view
branch
from
9d56758 to
39d1921
Compare
マージしない場合は、RequestとResponse を分割表示しない。
add: Response受信時に選択中のパケットを更新
fix: Type欄が空欄になるバグを修正
…and response merging logic; replace hardcoded indices with constants for better readability
taka2233
force-pushed
the
feat/split-history-view
branch
from
77a9aaa to
91d6f5a
Compare
Contributor
|
https://dena.com/ の通信をとってみたところ、RequestとResponseを一画面で表示できてました。 ただし、下記3点が気になったので修正してもらえると助かります！
ご確認をお願いいたします！ |
taka2233
force-pushed
the
feat/split-history-view
branch
from
1566694 to
dfa9c28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC Streamingなどをストリーミング通信以外のRequestとResponseが1対1で対応づく通信を、Historyタブでマージして表示するようにしました。RequestとResponseが1画面で確認できるため、視認性が向上しています。
以下の条件を全て満たす場合に非ストリーミング通信と判断しています
ストリーミング通信
非ストリーミング通信
