Skip to content

profiling: switch profile exporter to ureq#1798

Draft
realFlowControl wants to merge 1 commit intomainfrom
florian/ureq
Draft

profiling: switch profile exporter to ureq#1798
realFlowControl wants to merge 1 commit intomainfrom
florian/ureq

Conversation

@realFlowControl
Copy link
Copy Markdown
Member

@realFlowControl realFlowControl commented Mar 25, 2026

Warning

This is vibe coded and I have not spend a second checking the code. I gave it a try in https://github.com/DataDog/dd-trace-php/tree/florian/ureq and it works, so thats something :-D

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

Brings PHP Profiler binary size down by ~2.5 MB (from 16 to 13.3 on amd64 and from 14.5 to 12 on aarch64).

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@datadog-prod-us1-5
Copy link
Copy Markdown

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 2 Tests failed

test_export_agentless_named_pipe from libdd-profiling::exporter_e2e   View in Datadog   (Fix with Cursor)
Error: named pipe E2E tests are not implemented without tokio

Error: named pipe E2E tests are not implemented without tokio

Stack backtrace:
   0: std::backtrace_rs::backtrace::win64::trace
             at /rustc/01f6ddf7588f42ae2d7eb0a2f21d44e8e96674cf/library\std\src\..\..\backtrace\src\backtrace\win64.rs:85
   1: std::backtrace_rs::backtrace::trace_unsynchronized
             at /rustc/01f6ddf7588f42ae2d7eb0a2f21d44e8e96674cf/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66
   2: std::backtrace::Backtrace::create
...
test_export_agent_named_pipe from libdd-profiling::exporter_e2e   View in Datadog   (Fix with Cursor)
Error: named pipe E2E tests are not implemented without tokio

Error: named pipe E2E tests are not implemented without tokio

Stack backtrace:
   0: std::backtrace_rs::backtrace::win64::trace
             at /rustc/01f6ddf7588f42ae2d7eb0a2f21d44e8e96674cf/library\std\src\..\..\backtrace\src\backtrace\win64.rs:85
   1: std::backtrace_rs::backtrace::trace_unsynchronized
             at /rustc/01f6ddf7588f42ae2d7eb0a2f21d44e8e96674cf/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66
   2: std::backtrace::Backtrace::create
...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 20cd26b | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant