test(crashtracker): replace express with core http#89
Draft
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
watson
force-pushed
the
watson/drop-3rd-party-deps
branch
from
c3ded24 to
13eccc1
Compare
watson
force-pushed
the
watson/drop-3rd-party-deps
branch
from
13eccc1 to
54282e4
Compare
Remove express and body-parser dependencies in favor of Node.js core http module. This simplifies the test setup and eliminates third-party dependencies. The yarn install step is moved from the test runner script into the test itself.
watson
force-pushed
the
watson/drop-3rd-party-deps
branch
from
54282e4 to
5c4b7c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
expressandbody-parserwith Node.js corehttpmodule intest/crashtracker/index.js, eliminating third-party test dependencies. Theyarn installstep is moved fromscripts/test.shinto the test itself so it manages its own dependency setup.