Conversation
Overall package sizeSelf size: 37.03 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
…don't know how to do it in js
… for httpresponse
…omment saying it does not work
| const parsed = new URL(url); | ||
| const transport = parsed.protocol === 'https:' ? https : http; | ||
|
|
||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
Using a promise here is a bit of a code smell. That said, it's the easiest to map to Futures, so I'm fine with keeping it here.
There was a problem hiding this comment.
Do you mean like using fetch directly that returns "natively" a Promise ? Or not using promises at all ?
| /// Parse response headers from a JS object `{ "header-name": "value", ... }`. | ||
| /// | ||
| /// Node.js `res.headers` returns lowercased header names with string values. | ||
| fn parse_response_headers(result: &JsValue) -> Result<Vec<(String, String)>, HttpError> { |
There was a problem hiding this comment.
Dealing w/ JsValue directly can sometimes be a perf bottleneck. It's fine for now though. We can benchmark later.
Alternatives would be sending un-parsed headers (i.e. raw packet data) in here directly. Yep, that's a thing we can do.
We can also consider the network socket interface as a potential replacement layer here. Regardless, we have tons of room to figure that out and make improvements as we go, so this is all fine for now.
2 participants
ongoing effort to make libdatadog wasm compatible.