Conversation
Overall package sizeSelf size: 85.22 kB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
hoolioh
force-pushed
the
julio/codecov
branch
2 times, most recently
from
45f2217 to
5b71940
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
| - name: Install cargo-llvm-cov | ||
| uses: taiki-e/install-action@cargo-llvm-cov | ||
| - name: Generate code coverage | ||
| run: cargo +nightly llvm-cov --all-features --workspace --lcov --output-path lcov.info |
There was a problem hiding this comment.
Does this run the tests? How does it figure out the coverage?
Also, do we even need Rust tests? Since this is a JavaScript binding, would just relying on JavaScript tests be enough?
There was a problem hiding this comment.
Yes, it runs the tests and gathers information as the test go. I believe it works in the same way as GCOV.
Well, since I was doing the same work for libdatadog repo I thought it could come in handy as we add more code to the repo. Having the report is useful to spot some areas of the code that should be tested.
For examlple in the IAST native modules we have native tests covering some specific areas that are hard to excersize from the JS side.
There was a problem hiding this comment.
Since this is just a binding on top of another library, I don't think we would (or should) need that. Especially since the pipeline is set up in a way that expects the compiled binary to be used for testing, and Cargo tests require compiling in-place with different settings than the final binary.
3 participants
Add Codecov integration.