Skip to content

Add .NET logo and fix C++ logo in SCA language support section#36939

Open
gorkavicente wants to merge 1 commit into
masterfrom
gorkavicente/sca-add-dotnet-logo
Open

Add .NET logo and fix C++ logo in SCA language support section#36939
gorkavicente wants to merge 1 commit into
masterfrom
gorkavicente/sca-add-dotnet-logo

Conversation

@gorkavicente
Copy link
Copy Markdown
Contributor

What does this PR do? What is the motivation?

Updates the SCA language support cards in the sca-lang-support.html partial:

  • Adds the .NET logo (using dotnet_avatar.svg) after the Java logo, where the Go logo previously appeared
  • Fixes the C++ logo entry (replaces the incorrectly used c_sharp.png with cpp.png) and corrects the alt text to c++

Both .NET and C++ are now properly represented in the language support grid.

Merge instructions

Merge readiness:

  • Ready for merge

Additional notes

@gorkavicente gorkavicente requested a review from a team as a code owner May 22, 2026 07:20
@drichards-87
Copy link
Copy Markdown
Contributor

@gorkavicente Just FYI, there’s a merge conflict in the partial file. I took a quick look, but I wasn’t sure how it should be resolved and didn’t want to mess up the changes you were making. Could you take a look?

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@gorkavicente gorkavicente force-pushed the gorkavicente/sca-add-dotnet-logo branch from c51595b to 89e244a Compare May 22, 2026 15:04
@github-actions github-actions Bot added the Architecture Everything related to the Doc backend label May 22, 2026
Copy link
Copy Markdown
Contributor

@StefonSimmons StefonSimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. One thing - every image card links to the same anchor, so the links aren't actually navigating users anywhere distinct. Should we drop the wrappers, or are there plans to link each language to its own section?
CC: @drichards-87

@drichards-87
Copy link
Copy Markdown
Contributor

The change looks good. One thing - every image card links to the same anchor, so the links aren't actually navigating users anywhere distinct. Should we drop the wrappers, or are there plans to link each language to its own section? CC: @drichards-87

@StefonSimmons I think we did have separate pages at one time, but then we removed them later. I agree though, if we don't have separate language-specific setup pages that we can link to, we should probably convert this to a list, instead of using a partial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants