feat(telemetry): add stable session identifier headers#195
Closed
khanayan123 wants to merge 2 commits intomainfrom
Closed
feat(telemetry): add stable session identifier headers#195khanayan123 wants to merge 2 commits intomainfrom
khanayan123 wants to merge 2 commits intomainfrom
Conversation
Implement the Stable Service Instance Identifier RFC for dd-trace-rs. - Add root_session_id field to Config, populated from DD_ROOT_RS_SESSION_ID env var (set by parent process) or falling back to runtime_id for root processes - Add root_session_id() getter on Config - Pass root_session_id to TelemetryWorkerBuilder so libdd-telemetry emits DD-Session-ID and DD-Root-Session-ID headers on all telemetry requests Depends on: DataDog/libdatadog#<libdatadog-pr> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Point all libdatadog workspace deps at the stable-session-identifier-headers branch so CI can compile builder.root_session_id. Revert to crates.io versions once the libdatadog PR is merged and published. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Stable Service Instance Identifier RFC for dd-trace-rs.
DD-Session-ID: present on every telemetry request (set toruntime_id)DD-Root-Session-ID: present only in child processes, inherited viaDD_ROOT_RS_SESSION_IDenv varConfiggains aroot_session_idfield: readsDD_ROOT_RS_SESSION_IDat init, falls back toruntime_idfor root processesChanges
src/core/configuration/configuration.rs:Config: addroot_session_id: &'static strfieldprocess_root_session_id(): readsDD_ROOT_RS_SESSION_IDenv var or falls back toruntime_idroot_session_id(): public gettersrc/core/telemetry.rs: passroot_session_idtoTelemetryWorkerBuilderDependencies
Blocked on: DataDog/libdatadog#1782 —
TelemetryWorkerBuilder::root_session_idfield must be published before this can compile against the released crate.CI will show a compile error on
builder.root_session_iduntil the libdatadog PR is merged and published.Related
Test plan
libdd-telemetryversion once feat(telemetry): add stable session identifier headers libdatadog#1782 is published