Add display name as parameter in JUnit5 dynamic tests#10649
Add display name as parameter in JUnit5 dynamic tests#10649gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomasterfrom
Conversation
Test Environment - sbt-scalatestJob Status: success
|
Test Environment - netflix-zuulJob Status: success
|
Test Environment - nebula-release-pluginJob Status: success
|
Test Environment - reactive-streams-jvmJob Status: success
|
Test Environment - pass4sJob Status: success
|
Test Environment - sonar-kotlinJob Status: success
|
Test Environment - jolokiaJob Status: success
|
Test Environment - okhttpJob Status: success
|
Test Environment - spring_bootJob Status: success
|
Test Environment - sonar-javaJob Status: success
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~1efe6a6641, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1093069
Total [baseline] (11.252 s) : 0, 11251601
Agent [candidate] (1.101 s) : 0, 1101196
Total [candidate] (11.31 s) : 0, 11309791
section appsec
Agent [baseline] (1.267 s) : 0, 1267327
Total [baseline] (11.308 s) : 0, 11307870
Agent [candidate] (1.27 s) : 0, 1270031
Total [candidate] (11.288 s) : 0, 11287675
section iast
Agent [baseline] (1.265 s) : 0, 1265207
Total [baseline] (11.464 s) : 0, 11464397
Agent [candidate] (1.275 s) : 0, 1274532
Total [candidate] (11.479 s) : 0, 11478734
section profiling
Agent [baseline] (1.226 s) : 0, 1225968
Total [baseline] (11.278 s) : 0, 11278112
Agent [candidate] (1.22 s) : 0, 1219631
Total [candidate] (11.446 s) : 0, 11445748
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~1efe6a6641, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.276 ms) : 0, 1276
crashtracking [candidate] (1.249 ms) : 0, 1249
BytebuddyAgent [baseline] (641.988 ms) : 0, 641988
BytebuddyAgent [candidate] (644.475 ms) : 0, 644475
AgentMeter [baseline] (29.765 ms) : 0, 29765
AgentMeter [candidate] (30.175 ms) : 0, 30175
GlobalTracer [baseline] (265.393 ms) : 0, 265393
GlobalTracer [candidate] (268.476 ms) : 0, 268476
AppSec [baseline] (34.057 ms) : 0, 34057
AppSec [candidate] (34.633 ms) : 0, 34633
Debugger [baseline] (67.955 ms) : 0, 67955
Debugger [candidate] (68.601 ms) : 0, 68601
Remote Config [baseline] (660.405 µs) : 0, 660
Remote Config [candidate] (671.902 µs) : 0, 672
Telemetry [baseline] (10.398 ms) : 0, 10398
Telemetry [candidate] (10.505 ms) : 0, 10505
Flare Poller [baseline] (4.729 ms) : 0, 4729
Flare Poller [candidate] (5.644 ms) : 0, 5644
section appsec
crashtracking [baseline] (1.25 ms) : 0, 1250
crashtracking [candidate] (1.243 ms) : 0, 1243
BytebuddyAgent [baseline] (669.837 ms) : 0, 669837
BytebuddyAgent [candidate] (671.786 ms) : 0, 671786
AgentMeter [baseline] (12.337 ms) : 0, 12337
AgentMeter [candidate] (12.348 ms) : 0, 12348
GlobalTracer [baseline] (265.005 ms) : 0, 265005
GlobalTracer [candidate] (265.881 ms) : 0, 265881
IAST [baseline] (26.276 ms) : 0, 26276
IAST [candidate] (26.206 ms) : 0, 26206
AppSec [baseline] (173.245 ms) : 0, 173245
AppSec [candidate] (174.045 ms) : 0, 174045
Debugger [baseline] (68.781 ms) : 0, 68781
Debugger [candidate] (67.871 ms) : 0, 67871
Remote Config [baseline] (665.185 µs) : 0, 665
Remote Config [candidate] (671.87 µs) : 0, 672
Telemetry [baseline] (9.677 ms) : 0, 9677
Telemetry [candidate] (9.643 ms) : 0, 9643
Flare Poller [baseline] (3.629 ms) : 0, 3629
Flare Poller [candidate] (3.68 ms) : 0, 3680
section iast
crashtracking [baseline] (1.26 ms) : 0, 1260
crashtracking [candidate] (1.253 ms) : 0, 1253
BytebuddyAgent [baseline] (813.536 ms) : 0, 813536
BytebuddyAgent [candidate] (820.843 ms) : 0, 820843
AgentMeter [baseline] (11.639 ms) : 0, 11639
AgentMeter [candidate] (11.741 ms) : 0, 11741
GlobalTracer [baseline] (256.43 ms) : 0, 256430
GlobalTracer [candidate] (257.449 ms) : 0, 257449
IAST [baseline] (28.328 ms) : 0, 28328
IAST [candidate] (28.842 ms) : 0, 28842
AppSec [baseline] (35.643 ms) : 0, 35643
AppSec [candidate] (35.294 ms) : 0, 35294
Debugger [baseline] (68.526 ms) : 0, 68526
Debugger [candidate] (69.294 ms) : 0, 69294
Remote Config [baseline] (581.308 µs) : 0, 581
Remote Config [candidate] (572.349 µs) : 0, 572
Telemetry [baseline] (8.917 ms) : 0, 8917
Telemetry [candidate] (8.919 ms) : 0, 8919
Flare Poller [baseline] (3.61 ms) : 0, 3610
Flare Poller [candidate] (3.593 ms) : 0, 3593
section profiling
crashtracking [baseline] (1.253 ms) : 0, 1253
crashtracking [candidate] (1.244 ms) : 0, 1244
BytebuddyAgent [baseline] (700.181 ms) : 0, 700181
BytebuddyAgent [candidate] (697.045 ms) : 0, 697045
AgentMeter [baseline] (8.889 ms) : 0, 8889
AgentMeter [candidate] (8.813 ms) : 0, 8813
GlobalTracer [baseline] (225.067 ms) : 0, 225067
GlobalTracer [candidate] (224.44 ms) : 0, 224440
AppSec [baseline] (34.067 ms) : 0, 34067
AppSec [candidate] (33.698 ms) : 0, 33698
Debugger [baseline] (70.429 ms) : 0, 70429
Debugger [candidate] (69.299 ms) : 0, 69299
Remote Config [baseline] (680.668 µs) : 0, 681
Remote Config [candidate] (677.516 µs) : 0, 678
Telemetry [baseline] (9.389 ms) : 0, 9389
Telemetry [candidate] (9.248 ms) : 0, 9248
Flare Poller [baseline] (3.946 ms) : 0, 3946
Flare Poller [candidate] (3.778 ms) : 0, 3778
ProfilingAgent [baseline] (100.156 ms) : 0, 100156
ProfilingAgent [candidate] (99.758 ms) : 0, 99758
Profiling [baseline] (100.749 ms) : 0, 100749
Profiling [candidate] (100.352 ms) : 0, 100352
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~1efe6a6641, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087942
Total [baseline] (9.322 s) : 0, 9322456
Agent [candidate] (1.091 s) : 0, 1091396
Total [candidate] (9.38 s) : 0, 9380166
section iast
Agent [baseline] (1.26 s) : 0, 1259535
Total [baseline] (9.988 s) : 0, 9987766
Agent [candidate] (1.268 s) : 0, 1267533
Total [candidate] (9.951 s) : 0, 9950775
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~1efe6a6641, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.237 ms) : 0, 1237
crashtracking [candidate] (1.25 ms) : 0, 1250
BytebuddyAgent [baseline] (639.375 ms) : 0, 639375
BytebuddyAgent [candidate] (640.828 ms) : 0, 640828
AgentMeter [baseline] (29.58 ms) : 0, 29580
AgentMeter [candidate] (29.655 ms) : 0, 29655
GlobalTracer [baseline] (264.614 ms) : 0, 264614
GlobalTracer [candidate] (265.155 ms) : 0, 265155
AppSec [baseline] (33.572 ms) : 0, 33572
AppSec [candidate] (33.698 ms) : 0, 33698
Debugger [baseline] (66.641 ms) : 0, 66641
Debugger [candidate] (69.064 ms) : 0, 69064
Remote Config [baseline] (638.501 µs) : 0, 639
Remote Config [candidate] (635.237 µs) : 0, 635
Telemetry [baseline] (10.2 ms) : 0, 10200
Telemetry [candidate] (9.561 ms) : 0, 9561
Flare Poller [baseline] (5.502 ms) : 0, 5502
Flare Poller [candidate] (4.745 ms) : 0, 4745
section iast
crashtracking [baseline] (1.245 ms) : 0, 1245
crashtracking [candidate] (1.255 ms) : 0, 1255
BytebuddyAgent [baseline] (811.448 ms) : 0, 811448
BytebuddyAgent [candidate] (817.439 ms) : 0, 817439
AgentMeter [baseline] (11.59 ms) : 0, 11590
AgentMeter [candidate] (11.684 ms) : 0, 11684
GlobalTracer [baseline] (255.289 ms) : 0, 255289
GlobalTracer [candidate] (256.57 ms) : 0, 256570
IAST [baseline] (28.216 ms) : 0, 28216
IAST [candidate] (28.607 ms) : 0, 28607
AppSec [baseline] (37.101 ms) : 0, 37101
AppSec [candidate] (35.286 ms) : 0, 35286
Debugger [baseline] (65.165 ms) : 0, 65165
Debugger [candidate] (67.197 ms) : 0, 67197
Remote Config [baseline] (574.336 µs) : 0, 574
Remote Config [candidate] (556.501 µs) : 0, 557
Telemetry [baseline] (8.923 ms) : 0, 8923
Telemetry [candidate] (8.816 ms) : 0, 8816
Flare Poller [baseline] (3.592 ms) : 0, 3592
Flare Poller [candidate] (3.519 ms) : 0, 3519
LoadParameters
See matching parameters
SummaryFound 6 performance improvements and 1 performance regressions! Performance is the same for 12 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~1efe6a6641, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section baseline
no_agent (19.086 ms) : 18890, 19282
. : milestone, 19086,
appsec (18.269 ms) : 18085, 18453
. : milestone, 18269,
code_origins (17.631 ms) : 17459, 17803
. : milestone, 17631,
iast (17.61 ms) : 17435, 17785
. : milestone, 17610,
profiling (18.824 ms) : 18637, 19012
. : milestone, 18824,
tracing (18.606 ms) : 18420, 18791
. : milestone, 18606,
section candidate
no_agent (19.032 ms) : 18835, 19228
. : milestone, 19032,
appsec (18.708 ms) : 18521, 18895
. : milestone, 18708,
code_origins (18.354 ms) : 18169, 18540
. : milestone, 18354,
iast (17.416 ms) : 17242, 17589
. : milestone, 17416,
profiling (18.632 ms) : 18447, 18818
. : milestone, 18632,
tracing (17.505 ms) : 17333, 17677
. : milestone, 17505,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~1efe6a6641, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section baseline
no_agent (1.21 ms) : 1198, 1222
. : milestone, 1210,
iast (3.139 ms) : 3101, 3177
. : milestone, 3139,
iast_FULL (5.882 ms) : 5823, 5941
. : milestone, 5882,
iast_GLOBAL (3.649 ms) : 3593, 3705
. : milestone, 3649,
profiling (2.175 ms) : 2154, 2195
. : milestone, 2175,
tracing (1.842 ms) : 1826, 1857
. : milestone, 1842,
section candidate
no_agent (1.166 ms) : 1155, 1177
. : milestone, 1166,
iast (3.173 ms) : 3126, 3220
. : milestone, 3173,
iast_FULL (5.661 ms) : 5606, 5717
. : milestone, 5661,
iast_GLOBAL (3.371 ms) : 3322, 3420
. : milestone, 3371,
profiling (2.093 ms) : 2074, 2112
. : milestone, 2093,
tracing (1.806 ms) : 1791, 1821
. : milestone, 1806,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~1efe6a6641, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section baseline
no_agent (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
appsec (14.889 s) : 14889000, 14889000
. : milestone, 14889000,
iast (18.306 s) : 18306000, 18306000
. : milestone, 18306000,
iast_GLOBAL (18.032 s) : 18032000, 18032000
. : milestone, 18032000,
profiling (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
tracing (14.56 s) : 14560000, 14560000
. : milestone, 14560000,
section candidate
no_agent (15.316 s) : 15316000, 15316000
. : milestone, 15316000,
appsec (14.87 s) : 14870000, 14870000
. : milestone, 14870000,
iast (18.258 s) : 18258000, 18258000
. : milestone, 18258000,
iast_GLOBAL (17.702 s) : 17702000, 17702000
. : milestone, 17702000,
profiling (14.843 s) : 14843000, 14843000
. : milestone, 14843000,
tracing (14.75 s) : 14750000, 14750000
. : milestone, 14750000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~1efe6a6641, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.5 ms) : 2445, 2554
. : milestone, 2500,
iast (2.241 ms) : 2172, 2310
. : milestone, 2241,
iast_GLOBAL (2.284 ms) : 2215, 2353
. : milestone, 2284,
profiling (2.066 ms) : 2011, 2120
. : milestone, 2066,
tracing (2.045 ms) : 1993, 2098
. : milestone, 2045,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.753 ms) : 3532, 3973
. : milestone, 3753,
iast (2.246 ms) : 2178, 2315
. : milestone, 2246,
iast_GLOBAL (2.288 ms) : 2218, 2357
. : milestone, 2288,
profiling (2.099 ms) : 2043, 2155
. : milestone, 2099,
tracing (2.052 ms) : 1999, 2105
. : milestone, 2052,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This PR is rejected because it was updated |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
{"metadata": {"test_name": displayName}}.test.junit5.is_dynamicis introduced to differentiate between actual parameterized tests and dynamic tests.Motivation
The changes allow dynamically generated tests to have independent fingerprints. Previously, they were reported with the method name (in this case the factory method) as
test.name, which made it impossible for our backend to differentiate between all dynamic tests inside the same factory. The factory method is still kept as test name to avoid possible issues where different dynamic tests might have identical display names, which would cause collisions in features such as EFD or FTM.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.