[SVLS-8660] ci: add Copilot instructions for PII and security review#1133
Open
litianningdatadog wants to merge 1 commit intomainfrom
Open
[SVLS-8660] ci: add Copilot instructions for PII and security review#1133litianningdatadog wants to merge 1 commit intomainfrom
litianningdatadog wants to merge 1 commit intomainfrom
Conversation
litianningdatadog
force-pushed
the
tianning.li/SVLS-8660-ci-checks
branch
from
48b04bb to
7a3cbdc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a repository-level .github/copilot-instructions.md to steer GitHub Copilot’s auto-review toward security-relevant patterns (PII/secrets in logs, unsafe Rust invariants, and error handling issues).
Changes:
- Introduces Copilot review guidance to flag potentially sensitive logging (headers/bodies/user-identifiable fields/secrets).
- Adds instructions to flag new Rust
unsafeusage and require explicit safety invariants / safe alternatives. - Adds instructions to flag problematic error handling patterns in external-input/network paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
litianningdatadog
force-pushed
the
tianning.li/SVLS-8660-ci-checks
branch
from
bff65bd to
a36befb
Compare
3 tasks
litianningdatadog
force-pushed
the
tianning.li/SVLS-8660-ci-checks
branch
2 times, most recently
from
ceb084e to
530325e
Compare
- Add .github/copilot-instructions.md to steer Copilot auto-review
toward security-relevant patterns
- Flag PII in log statements: HTTP headers/bodies, user-identifiable
fields, secrets — covering all tracing macro forms including
unqualified info!/debug!/warn!/error! used via use tracing::{...}
- Flag new unsafe blocks with required safety invariant explanation
- Flag silently swallowed errors (.ok(), let _ = result) and
panicking operations (.unwrap()/.expect()) in network/input paths
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
litianningdatadog
force-pushed
the
tianning.li/SVLS-8660-ci-checks
branch
from
530325e to
faba926
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/copilot-instructions.mdto guide GitHub Copilot auto-review toward security-relevant patterns on every PRunsafeRust blocks with missing invariant documentationContext
Jira: https://datadoghq.atlassian.net/browse/SVLS-8660
This is the first deliverable of the CI security scanning strategy (Approach C — phased).
Copilot auto-review is confirmed enabled for this repo, making this a zero-overhead advisory
layer at PR open/update time. Full strategy documented in
.github/docs/ci-security-scanning-strategy.md.Test plan
🤖 Generated with Claude Code