Skip to content

CONTINT-5286 - add new action in remote config k8s actions#49331

Open
lavigne958 wants to merge 2 commits intomainfrom
crayon/CONTINT-5286_kube_action_get_resource
Open

CONTINT-5286 - add new action in remote config k8s actions#49331
lavigne958 wants to merge 2 commits intomainfrom
crayon/CONTINT-5286_kube_action_get_resource

Conversation

@lavigne958
Copy link
Copy Markdown
Contributor

What does this PR do?

This is a temporary action implementation.

Add the new action, it won't pass validation due to missing type in the proto definition. This is un purpose until it's ready.

Motivation

Describe how you validated your changes

Additional Notes

depends on DataDog/agent-payload#472

This is a temporary action implementation.

Add the new action, it won't pass validation due to missing type in the
proto definition. This is un purpose until it's ready.

Signed-off-by: Alexandre Lavigne <alexandre.lavigne@datadoghq.com>
@lavigne958 lavigne958 self-assigned this Apr 14, 2026
@lavigne958 lavigne958 requested a review from a team as a code owner April 14, 2026 16:22
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Apr 14, 2026
@github-actions github-actions bot added the medium review PR review might take time label Apr 14, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28db604c5c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread pkg/clusteragent/kubeactions/executors/get_resource.go Outdated
Comment thread pkg/clusteragent/kubeactions/executors/get_resource.go Outdated
@lavigne958 lavigne958 added the qa/no-code-change No code change in Agent code requiring validation label Apr 14, 2026
@lavigne958 lavigne958 marked this pull request as draft April 14, 2026 16:28
@lavigne958
Copy link
Copy Markdown
Contributor Author

currently in draft to validate some details

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Apr 14, 2026

Files inventory check summary

File checks results against ancestor 7852cc86:

Results for datadog-agent_7.79.0~devel.git.712.d05f361.pipeline.107813809-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Apr 14, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a5a17dda-3d47-490c-a122-9ac1422b79ee

Baseline: 7852cc8
Comparison: d05f361
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -0.00 [-3.03, +3.03] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +2.21 [+2.01, +2.41] 1 Logs
ddot_logs memory utilization +0.48 [+0.42, +0.54] 1 Logs
quality_gate_idle memory utilization +0.38 [+0.32, +0.43] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.18 [+0.09, +0.26] 1 Logs
ddot_metrics memory utilization +0.08 [-0.10, +0.26] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.08 [-0.39, +0.55] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.09, +0.17] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.49, +0.56] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.40, +0.43] 1 Logs
otlp_ingest_logs memory utilization +0.01 [-0.09, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.11, +0.12] 1 Logs
quality_gate_metrics_logs memory utilization -0.00 [-0.23, +0.23] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -0.00 [-3.03, +3.03] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.02 [-0.24, +0.20] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.03 [-0.25, +0.20] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.05 [-0.19, +0.10] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.11 [-0.17, -0.05] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.16 [-0.38, +0.07] 1 Logs
otlp_ingest_metrics memory utilization -0.18 [-0.34, -0.02] 1 Logs
file_tree memory utilization -0.23 [-0.29, -0.17] 1 Logs
ddot_metrics_sum_delta memory utilization -0.33 [-0.50, -0.17] 1 Logs
quality_gate_idle_all_features memory utilization -0.39 [-0.43, -0.35] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.41 [-3.02, +0.20] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 712 ≥ 26
docker_containers_memory memory_usage 10/10 282.68MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 707 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 177.14MiB ≤ 181MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 498.57MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 207.89MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 416.72 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 408.40MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@lavigne958 lavigne958 marked this pull request as ready for review April 15, 2026 13:46
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d05f3610cf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +37 to +41
resource := action.Resource
namespace := strings.ToLower(resource.GetNamespace())
name := strings.ToLower(resource.GetName())
apiVersion := strings.ToLower(resource.GetApiVersion())
kind := strings.ToLower(resource.GetKind())
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Verify resource UID before returning fetched object

This executor ignores resource.resource_id, so a get_resource action can return the wrong object if the original resource was deleted and recreated with the same name before execution. In that race, the action still reports success but the payload belongs to a different UID than the one the action was authored for. Other kubeactions executors already compare UID to resource_id; this path should do the same before returning the fetched body.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation qa/skip-qa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant