Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d6def5716
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // "merge" - RFC 7386 JSON merge patch, simple merge that replaces arrays entirely | ||
| // "json" - RFC 6902 JSON patch, explicit add/remove/replace operations at specific paths | ||
| // If not specified, defaults to "strategic-merge". | ||
| string patch_strategy = 2; |
There was a problem hiding this comment.
Adding patch_strategy here updates the IDL but the commit does not update the checked-in generated outputs (kubeactions/kubeactions.pb.go still exposes only Patch []byte, and kubeactions/jsonschema/PatchDeploymentParams.json still describes only strategic merge semantics). Because this repository ships generated bindings, downstream users of the committed Go/JSON artifacts cannot use the new field, so the API change is effectively incomplete until codegen outputs are regenerated and committed together.
Useful? React with 👍 / 👎.
2 participants
What does this PR do?
Updates patch params
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Reviewers: please see the review guidelines.