Add node-gyp-build-major parameter to support v4 naming convention#90
Merged
Add node-gyp-build-major parameter to support v4 naming convention#90
Conversation
node-gyp-build v4 changed prebuild naming from:
prebuilds/${platform}${libc}-${arch}/node-${abi}.node
to a tag-based convention:
prebuilds/${platform}-${arch}/${name}[.musl].node.[napi|abi${N}].node
Add NODE_GYP_BUILD_MAJOR (default: 3) to prebuild/index.js, exposed as
node-gyp-build-major workflow input. When set to 4:
- Directory: platform-arch (no libc suffix; glibc is assumed by default)
- Filename: name[.musl].node.[napi|abi${N}].node (libc encoded as tag)
- Artifact upload uses prebuilds/**/* to match the new directory names
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rochdev
approved these changes
Mar 5, 2026
szegedi
added a commit
that referenced
this pull request
Mar 23, 2026
PR #90 refactored prebuild output naming into a shared prebuildFilename() function, but the v3 code path hardcoded the "node-{abi}.node" prefix, ignoring the baseName parameter. This broke Rust builds which previously preserved the original binary name from build/Release/ (e.g. "process-discovery-napi.node" became "node-napi.node"), causing consumers like libdatadog-nodejs to fail with "Could not find a {name} binary for {platform}". The fix makes prebuildFilename() use baseName in the v3 path, and passes 'node' from the non-Rust call site to preserve backward compatibility there. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
szegedi
added a commit
that referenced
this pull request
Mar 23, 2026
Move prebuildDir and prebuildFilename into prebuild/naming.js as pure functions (all dependencies passed as parameters) so they can be tested in isolation. Add test/naming.js covering v3 and v4 naming for both Rust (dynamic baseName) and non-Rust (fixed 'node' prefix) builds. This would have caught the regression in PR #90 where v3 Rust builds lost the original binary name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
szegedi
added a commit
that referenced
this pull request
Mar 23, 2026
* Fix v3 prebuild naming for Rust builds PR #90 refactored prebuild output naming into a shared prebuildFilename() function, but the v3 code path hardcoded the "node-{abi}.node" prefix, ignoring the baseName parameter. This broke Rust builds which previously preserved the original binary name from build/Release/ (e.g. "process-discovery-napi.node" became "node-napi.node"), causing consumers like libdatadog-nodejs to fail with "Could not find a {name} binary for {platform}". The fix makes prebuildFilename() use baseName in the v3 path, and passes 'node' from the non-Rust call site to preserve backward compatibility there. Test have also been added to cover the functionality. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-gyp-build-majorworkflow input (default:3) to opt into the v4 prebuild naming conventionnode-gyp-buildv4 changed from directory-encoded libc (linuxglibc-arm64/node-115.node) to tag-based filenames (linux-arm64/dd_pprof.node.abi115.node)4, the action generates prebuilds with the new convention:prebuilds/${platform}-${arch}/(no libc in dir name)${TARGET_NAME}[.musl].node.[napi|abi${N}].node(libc encoded as.musltag; glibc is the default and needs no tag)prebuilds/**/*for v4 (since directory names no longer match job names)node-gyp-build-majoris not set (defaults to3)Motivation
Needed by pprof-nodejs#284 which bumps
node-gyp-buildfrom 3.x to 4.x.Test plan
node-gyp-build-major: 3node-gyp-build-major: 4🤖 Generated with Claude Code
Jira: PROF-14113