Open
Conversation
Update all 20 internal composite action references from 679d80c (pre-PR#100) to 287165b (current main HEAD). The previous pin predated PR #100 ("Fix v3 prebuild naming for Rust builds"), so the prebuild step was still using the buggy prebuildFilename() that hardcodes `node-napi.node` for v3 builds, ignoring the actual crate name. This caused all Rust binaries to overwrite each other, leaving only one file in the artifact. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PR #101 unconditionally installs autoconf/automake/libtool in all Alpine Docker builds. The libtool package causes SIGSEGV in Neon Alpine tests. Pin to dfb3666 (PR #100) which includes the v3 naming fix without the autotools change. Consumers that need autotools (e.g. libdatadog-nodejs) already handle this via the `prebuild` input hook. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
679d80c5todfb3666f(PR Fix v3 prebuild naming for Rust builds #100)prebuildcomposite action was still using the buggyprebuildFilename()that hardcodesnode-napi.nodefor v3 builds, ignoring the actual crate nameWhy not pin to HEAD (
287165bc)?The initial version of this PR pinned to
287165bc(main HEAD), which includes both PR #100 and PR #101. PR #101 unconditionally installsautoconf/automake/libtoolin all Alpine Docker builds. Thelibtoolpackage causes SIGSEGV in the Neon Alpine test suite at test time (builds succeed but the resulting.nodebinary segfaults on load).Pinning to
dfb3666f(PR #100 only) includes the naming fix without the autotools change. Consumers that need autotools (e.g. libdatadog-nodejs) already handle this via theprebuildinput hook, so PR #101's change to the Docker entrypoint is unnecessary and should likely be reverted separately.Test plan
🤖 Generated with Claude Code