Merged
Conversation
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
This comment was marked as outdated.
This comment was marked as outdated.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refines the web-sdk GitHub Actions workflow by normalizing naming, simplifying branch triggers, tightening Node and package manager configuration, and replacing the previous Cloudflare Pages deployment with a (partially defined) Next.js to GitHub Pages deployment scaffold. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The updated workflow YAML appears structurally invalid: there are now two top-level
on:blocks and a strayname: Deploy Next.js site to Pagesat the bottom, which will cause the workflow to fail to load; please consolidate this into a single workflow definition. - The
node-versionvalue'18''20''22'is not valid syntax foractions/setup-node; if you intend to support multiple Node versions, use a build matrix or specify a single version string (e.g.node-version: '20').
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The updated workflow YAML appears structurally invalid: there are now two top-level `on:` blocks and a stray `name: Deploy Next.js site to Pages` at the bottom, which will cause the workflow to fail to load; please consolidate this into a single workflow definition.
- The `node-version` value `'18''20''22'` is not valid syntax for `actions/setup-node`; if you intend to support multiple Node versions, use a build matrix or specify a single version string (e.g. `node-version: '20'`).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update the web-sdk GitHub Actions workflow to use a simplified pnpm-based setup and begin transitioning from a Cloudflare Pages deployment to a GitHub Pages/Next.js deployment configuration.
Build: