Skip to content

Update web-sdk.yml#377

Merged
Dargon789 merged 1 commit intowagmi-projectfrom
Dargon789-patch-1
Mar 17, 2026
Merged

Update web-sdk.yml#377
Dargon789 merged 1 commit intowagmi-projectfrom
Dargon789-patch-1

Conversation

@Dargon789
Copy link
Copy Markdown
Owner

@Dargon789 Dargon789 commented Mar 17, 2026

Summary by Sourcery

Update the web-sdk GitHub Actions workflow to use a simplified pnpm-based setup and begin transitioning from a Cloudflare Pages deployment to a GitHub Pages/Next.js deployment configuration.

Build:

  • Adjust the web-sdk workflow naming and branch triggers to target only the master branch for pull requests and pushes.
  • Update the Node setup to use pnpm caching exclusively and install Web SDK dependencies via pnpm instead of multiple package managers.
  • Remove the existing Cloudflare Pages deployment step and introduce the scaffold of a Next.js-to-GitHub Pages deployment workflow.

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@codesandbox
Copy link
Copy Markdown

codesandbox bot commented Mar 17, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@vercel

This comment was marked as outdated.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Mar 17, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refines the web-sdk GitHub Actions workflow by normalizing naming, simplifying branch triggers, tightening Node and package manager configuration, and replacing the previous Cloudflare Pages deployment with a (partially defined) Next.js to GitHub Pages deployment scaffold.

File-Level Changes

Change Details Files
Normalize workflow and job naming conventions in the web-sdk GitHub Actions workflow.
  • Rename the workflow from 'Web-SDK' to 'web-sdk'.
  • Rename the job step from 'Web SDK' to 'web-sdk' for consistency.
.github/workflows/web-sdk.yml
Adjust workflow triggers to only use the master branch and introduce a new push trigger block for a Next.js deployment flow.
  • Remove 'main' from pull_request branch filters, leaving only 'master'.
  • Remove 'main' from the original push branch filters, then add a new push trigger section that targets the 'master' branch for the Next.js deployment example.
.github/workflows/web-sdk.yml
Simplify Node setup and dependency installation configuration.
  • Change the Node.js version list to a malformed single string containing '18''20''22' which likely needs correction to an array format.
  • Restrict the dependency cache to pnpm only instead of yarn, npm, and pnpm.
  • Remove multiple commented install variants and keep a single pnpm install command for the web-sdk dependencies.
.github/workflows/web-sdk.yml
Remove Cloudflare Pages deployment and partially replace it with a Next.js-to-GitHub-Pages deployment scaffold.
  • Delete the Cloudflare Pages deployment step and all associated secrets configuration.
  • Insert commented documentation for a sample workflow to deploy a Next.js site to GitHub Pages.
  • Add a new (but syntactically suspiciously indented) step name 'Deploy Next.js site to Pages' and a secondary 'on: push' block describing pushes to 'master' for the Next.js deployment.
.github/workflows/web-sdk.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Mar 17, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The updated workflow YAML appears structurally invalid: there are now two top-level on: blocks and a stray name: Deploy Next.js site to Pages at the bottom, which will cause the workflow to fail to load; please consolidate this into a single workflow definition.
  • The node-version value '18''20''22' is not valid syntax for actions/setup-node; if you intend to support multiple Node versions, use a build matrix or specify a single version string (e.g. node-version: '20').
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The updated workflow YAML appears structurally invalid: there are now two top-level `on:` blocks and a stray `name: Deploy Next.js site to Pages` at the bottom, which will cause the workflow to fail to load; please consolidate this into a single workflow definition.
- The `node-version` value `'18''20''22'` is not valid syntax for `actions/setup-node`; if you intend to support multiple Node versions, use a build matrix or specify a single version string (e.g. `node-version: '20'`).

Fix all in Cursor


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit 5d83fa1 into wagmi-project Mar 17, 2026
13 of 17 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-1 branch March 17, 2026 23:24
@Dargon789 Dargon789 linked an issue Mar 18, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vc]: #wagmi@foundry-deployment-team

1 participant