[WIP] [arch/ball] Add MXFP ball prototype and test#31
Conversation
…d RVV insts to RoCC [arch/gpdomain] feat: add General Purpose Domain [arch/frontend] feat: add domain id and docoder [doc] fix: remove files' deleted link [bb-tests/ctest] feat: add VSETVLI test (can be sent to gpdomain)
[compiler] update: bump to the latest version
…details to prepare for backend virtualization. (DangoSys#19)
…nstallation script
[arch/palladium] feat: add 256CoreCrossBarConfig
feat: update Module initialisation with instantiable wip: replace spad and acc with banks [pre-commit] feat: add scalafmt
…ng and add ReluBall support
…improve ReluBall integration
…e customisation of blink status signals. feat: add domain channels
…el memory channel configurations
…BSimHarness configuration
[bb-tests] refacotr: update DISA for new funct7 encoding [arch] feat: enhance instruction tracing with bank enable support [bb-tests] feat: add different gemmini tests
…ing mechanism [bdb] refactor: refomat trace files
… clock cycle support
…scripts to use rust toolchain
[bb-tests] fix: Linux workload use bdb bug
…ts to reflect changes
[compiler] update: bump compiler
…ccel functionality
shirohasuki
left a comment
shirohasuki
left a comment
There was a problem hiding this comment.
Well progress for first try, I think it can soon be able to merge it into the main branch after your next commit.
| #define BLOCK_ELEMS 16 | ||
| #define NUM_BLOCKS 16 | ||
|
|
||
| #define BANK_WORD_BYTES 16 // 128-bit bank word |
There was a problem hiding this comment.
A minor slip: I suggest moving the comment to the previous line rather than placing it at the end of the line (according to google style guides).
| return (uint8_t)(shifted & 0xfu); | ||
| } | ||
|
|
||
| static void pack_mx6_block(const uint32_t *block_in, uint8_t *block_out_16B) { |
There was a problem hiding this comment.
Since we’ve specified a fixed input, I think it might be easier to understand if we simply write the corresponding output (you can include the process in the comments). Also, these validation functions are brilliant, but I think it might be better to place them in the library functions like buckyball.c
While we envisage ctest as the simplest test case, users will learn the most basic usage of this command here, rather than the algorithmic logic. In any case, it’s passable; let’s take it a step further to make it even better.
| val DEQUANT = BitPat("b0110100") // 52 (0x34) | ||
| val GEMMINI_PRELOAD = BitPat("b0110101") // 53 (0x35) | ||
| val BDB_BACKDOOR = BitPat("b0110110") // 54 (0x36) | ||
| val MXFP = BitPat("b0110111") // 55 (0x37) |
There was a problem hiding this comment.
Well done, you’ve chosen the right function code (1 read + 1 write)
shirohasuki
changed the title
shirohasuki
changed the title
shirohasuki
force-pushed
the
main
branch
2 times, most recently
from
2a837aa to
66be48c
Compare
5 participants
Summary
Validation
Notes
Closes #26