Skip to content

Introduces TPGLIBS_ENABLE_STATE_MONITORING CMake option (OFF by defau…#40

Open
xinyue-uoft wants to merge 2 commits into
developfrom
theo/buildoption
Open

Introduces TPGLIBS_ENABLE_STATE_MONITORING CMake option (OFF by defau…#40
xinyue-uoft wants to merge 2 commits into
developfrom
theo/buildoption

Conversation

@xinyue-uoft
Copy link
Copy Markdown
Contributor

@xinyue-uoft xinyue-uoft commented Apr 21, 2026

Gates the ProcessorInternalState infrastructure via #ifdef. Monitoring, process checking, registration, and unit-tests are excluded from code level when off.

Description

See issue #39 for details
Addresses issue #39

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh) (tpg_state_collection test fails due to new ERS warning unexpected. Will be fixed.
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Test in progress.

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

…lt) that gates the ProcessorInternalState* infrastructure via #ifdef. Monitoring, process checking, registration, and unit-tests are excluded from code level when off.
@xinyue-uoft
Copy link
Copy Markdown
Contributor Author

Note: CI Linting error purely due to the accompanied changes in tpglibs, not an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants