Reorganized the integration test parameters that developers use to specify a DUNE DAQ configuration#155
Open
bieryAtFnal wants to merge 6 commits into
Open
Reorganized the integration test parameters that developers use to specify a DUNE DAQ configuration#155bieryAtFnal wants to merge 6 commits into
bieryAtFnal wants to merge 6 commits into
Conversation
…easier to understand.
… specify from drunc_config to integtest_params in integrationtest_drunc.py
3 tasks
This was referenced May 13, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... The goal is to help make integtests easier to write and understand.
Description
These changes are intended for
fddaq-v5.7.0.The parameters that developers use to tell the
integrationtestinfrastructure about the characteristics of a requested regression/integration test have historically been a little confusing (at least to me).The goal of the changes in this PR and the related ones in several other repositories is to make integration tests easier to understand.
A first example of how these changes attempt to do this is the following:
object_databases) to request that the DUNE-DAQ configuration be generated by the integrationtest infrastructure, andThe
integtest_params_for_generated_dunedaq_configPython dataclass has been introduced to request a generated DUNE-DAQ configuration, and it has fields that are appropriate for such generation.The
integtest_params_for_predefined_dunedaq_configPython dataclass has been introduced to specify a pre-defined DUNE-DAQ configuration, and it has field(s) that are tailored to pre-defined DUNE-DAQ configurations.Examples of the use of these dataclasses are available in the updated integtests in various repositories. Here is a snippet of code from the
minimal_system_quick_testthat requests/specifies a generated DUNE-DAQ configuration:Here is a snippet of code from the
example_system_testthat requests/specifies that a pre-defined DUNE-DAQ configuration be used:The changes in this repository are primarily related to the introduction of these two new dataclasses and the switch to using them. The changes in the
daqsystemtest,dfmodules,hsilibs,listrev,snbmodules, andtriggerrepositories were needed to keep the various integtests in sync with these changes.Here are the PRs for the changes in other repositories that are correlated with this one:
Here are suggested instructions for testing these changes:
Type of change
Testing checklist
pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)Further checks