Skip to content

Johnfreeman/daq deliverables issue214 no moo#162

Merged
jcfreeman2 merged 6 commits into
developfrom
johnfreeman/daq-deliverables_issue214_no_moo
Apr 23, 2026
Merged

Johnfreeman/daq deliverables issue214 no moo#162
jcfreeman2 merged 6 commits into
developfrom
johnfreeman/daq-deliverables_issue214_no_moo

Conversation

@jcfreeman2
Copy link
Copy Markdown
Contributor

@jcfreeman2 jcfreeman2 commented Apr 22, 2026

Description

See issue DUNE-DAQ/daq-deliverables#214 for details

This should only be merged in concert with accompanying pull requests from other repositories with johnfreeman/daq-deliverables_issue214_no_moo branches.

As this change involves removal of *.jsonnet and its processing by moo, vendoring moo-generated C++ headers into the repo where applicable, testing will basically be regression and ensuring nothing broke. Note that RMDFD_DEV_260421_A9 is a test build (https://github.com/DUNE-DAQ/daq-release/actions/runs/24742300160) using this feature branch and both integration tests (https://github.com/DUNE-DAQ/daq-release/actions/runs/24746145786) and extended integration tests (https://github.com/DUNE-DAQ/daq-release/actions/runs/24752141578) appear normal.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jcfreeman2 jcfreeman2 marked this pull request as ready for review April 22, 2026 15:11
@jcfreeman2
Copy link
Copy Markdown
Contributor Author

Approved; see Kurt's comment in parent Issue DUNE-DAQ/daq-deliverables#214

@jcfreeman2 jcfreeman2 merged commit 4055eb1 into develop Apr 23, 2026
4 checks passed
@jcfreeman2 jcfreeman2 deleted the johnfreeman/daq-deliverables_issue214_no_moo branch April 23, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants