Johnfreeman/daq deliverables issue214 no moo#162
Merged
jcfreeman2 merged 6 commits intoApr 23, 2026
Conversation
…lete daq_codegen function
…jsonnet-based configuration generation from the documentation
Contributor
Author
|
Approved; see Kurt's comment in parent Issue DUNE-DAQ/daq-deliverables#214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See issue DUNE-DAQ/daq-deliverables#214 for details
This should only be merged in concert with accompanying pull requests from other repositories with
johnfreeman/daq-deliverables_issue214_no_moobranches.As this change involves removal of
*.jsonnetand its processing by moo, vendoring moo-generated C++ headers into the repo where applicable, testing will basically be regression and ensuring nothing broke. Note thatRMDFD_DEV_260421_A9is a test build (https://github.com/DUNE-DAQ/daq-release/actions/runs/24742300160) using this feature branch and both integration tests (https://github.com/DUNE-DAQ/daq-release/actions/runs/24746145786) and extended integration tests (https://github.com/DUNE-DAQ/daq-release/actions/runs/24752141578) appear normal.Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))