WIB online test script by PawelPlesniak · Pull Request #853 · DUNE-DAQ/drunc

PawelPlesniak · 2026-03-18T11:16:53Z

Description

Defines a simple script to check the status of the WIBs. This will be extended to also check the FEMBs, the AMC crates, and the AMCs in the future. The use of this script will generate results as

Type of change

List of required branches from other repositories

N/A

Change log

Only the new script has been defined.

Suggested manual testing checklist

Clone this repo, switch to the branch, install it. Note, if using an existing branch, you wil need to re-install drunc as this changes the pyproject.toml. Run drunc-check-np0x-hw

Testing

Note - this has been skipped as this is a simple app that does not change the code internals.

MRiganSUSX

Thanks for this, going to be very useful for Ops!

I have a few suggestions:

as_completed is overcomplicated. Rich's Live already handles UI refreshing in the background, so many of the manual checks (while, timeout) are not necessary.
Suggested optimized loop:

    try:
        with Live(generate_table(results_map), console=console, refresh_per_second=10) as live:
            
            for future in as_completed(futures):
                ip = futures[future] 
                results_map[ip] = future.result()
                live.update(generate_table(results_map))

    except KeyboardInterrupt:
        pass

could we add additional formatting for the output tables? Something like coldboxes in one (separated) row, APAs in another one, CRPs in another one; all clearly separated (borders / line breaks)
for better maintenance, would it make sense to move the data dictionaries with IPs to an external json ?
and finally (and I know I should do this myself -_-) are the IPs correct? There are some jumps; just to double check.

…nc into PawelPlesniak/HWStatusCheck

PawelPlesniak · 2026-04-01T17:56:54Z

This has been updated to include the FEMB level status. In the cae that the dune-wib-firmware repo has been build in either the project root or sourcecode, you will see this

If you don't have the repo:

if you have the repo but the python is not installed:

PawelPlesniak · 2026-04-01T17:58:26Z

The IPs are correct. For the initial scope, I think leaving the IP addresses where they are is OK, in the future when this tool serves for the resource/asset/etc manager it can be more formal, but for now I think it is better as self-contained

emmuhamm

This is pretty cooool, thanks @PawelPlesniak!

The only major comment I have is the one about moving the check much earlier in the script so it can fail quickly, and to just show the warning (maybe they should be error?) messages if they havent set up the relevant stuff. No need to clutter the output with tables when it can't even be accessed.

Other than that, only a few python comments here and there.

Other info:

no msqt testing or higher done since this is a standalone app
Requires conflict fixing when rebasing on develop. Very simple though.
Also will try removing Michal's 'changes requested' thing to unblock this from coming in if necessary since he's quite busy

emmuhamm · 2026-05-06T14:23:30Z

+                try:
+                    wib_inst = WIB(ip)
+                    req = wibpb.GetFEMBStatus()
+                    rep = wibpb.GetFEMBStatus.FEMBStatus()
+                    # We wrap this in a sub-try because gRPC can hang
+                    wib_inst.send_command(req, rep)
+                    if hasattr(rep, "femb_power") and len(rep.femb_power) == 4:
+                        final_status["fembs"] = list(rep.femb_power)
+                    else:
+                        final_status["fembs"] = [False] * 4


More of my ignorance: How does wrapping this in a try prevent any issues if the device hangs?

I was wondering if theres any timeout clauses here that automatically fails this check if it exceeds eg 10 seconds. If not, it might just hang indefinitely?

To be reviewed more after release cut, but if the device is not responding to ping, then this get skipped. The WIB response is gRPC based in the dune_wib_firmware repo (sorry if typos), but if we can't connect to the server, then the connection would automatically fail.

Sounds good to me, thakns! Leaving this unresolved so you can review more after release cut

emmuhamm · 2026-05-06T14:23:55Z

+    if not WIB_LIB_AVAILABLE:
+        console.print("-" * 40)
+        console.print("[bold yellow]Hardware Communication Warning:[/]")
+        if WIB_FW_SW_IFACE_PATH:
+            console.print(
+                f"Modules found but not loaded. Try running [red]pip install zmq[/] and [red]make -o build/%.d python[/] in:\n[blue]{WIB_FW_SW_IFACE_PATH}[/]"
+            )
+        else:
+            console.print(
+                "Couldnt check wib status. [italic]dune-wib-firmware[/italic] repo not found."
+            )
+        console.print("-" * 40)


Highly recommend moving this much earlier.

I think it would be better if the script does this check first and then proceeds to prints the output tables if valid.

Its faster, and also less heart-attack inducing as seeing an ERROR: repo not found with instructions is better than seeing that everything is dead lmao.

We can have this earlier, but the point is that even without this repo, we can still check the WIB, but we can't check the FEMB. Not being able to check the FEMB is long term bad, but short term OK

Ah okay, wasn't aware between the two. In which case probably might still be better to hide the FEMB table output.

I dont think this is a blocker tho if this PR needs to go in particularly urgently

emmuhamm · 2026-05-06T14:33:33Z

+                    else:
+                        final_status["fembs"] = [False] * 4
+                except Exception:
+                    final_status["fembs"] = [False] * 4
+            else:
+                final_status["fembs"] = [False] * 4
+        else:
+            final_status["online"] = False
+            final_status["fembs"] = [False] * 4


Are all these else blocks really necessary?

If we have a defined list in python I would have expected them to remain unchanged. Would be nice to delete a whole lot of repetitive code

Suggested change

else:

final_status["fembs"] = [False] * 4

except Exception:

final_status["fembs"] = [False] * 4

else:

final_status["fembs"] = [False] * 4

else:

final_status["online"] = False

final_status["fembs"] = [False] * 4

except Exception:

pass

Needs review

emmuhamm · 2026-05-06T14:34:25Z

+                        final_status["fembs"] = list(rep.femb_power)
+                    else:
+                        final_status["fembs"] = [False] * 4
+                except Exception:


Normally I would argue against bare exceptions but this is a simple standalone app. Just to flag it up though mypy is not going to like this :)

Fair point, needs adressing

emmuhamm · 2026-05-06T14:38:01Z

+    # Add columns for WIB number and each of the 4 FEMBs, with centered text. The WIB
+    # number will be colored based on online status, and the FEMB columns will show
+    # icons based on their power status.


Useful info to include when running --help, as well as just having this information displayed somewhere in the output so they understand whats being printed.

Speaking of which, missing --help string (?)

@emmuhamm

unblocks this from coming in if needed
superseded by most recent review from @emmuhamm
I think comments have been addressed anyway
I hope this doesn't delete your comments >.<

Ready

caf9f2a

PawelPlesniak requested a review from MRiganSUSX March 18, 2026 11:19

PawelPlesniak changed the title ~~Ready~~ WIB online test script Mar 18, 2026

PawelPlesniak linked an issue Mar 19, 2026 that may be closed by this pull request

[Feature]: Extend the definition of drunc-check-np0x-hw to include more HW #854

Open

MRiganSUSX previously requested changes Mar 20, 2026

View reviewed changes

PawelPlesniak and others added 5 commits April 1, 2026 12:13

Merge branch 'develop' into PawelPlesniak/HWStatusCheck

51181c9

Requiring documentation but functional

22f7406

WIP

f2dfd0e

Merge branch 'PawelPlesniak/HWStatusCheck' of github.com:DUNE-DAQ/dru…

81881f5

…nc into PawelPlesniak/HWStatusCheck

Docs

c6e5cea

PawelPlesniak assigned MRiganSUSX Apr 16, 2026

bump

6c5e75a

emmuhamm self-requested a review May 6, 2026 09:10

emmuhamm requested changes May 6, 2026

View reviewed changes

emmuhamm assigned PawelPlesniak May 6, 2026

Conversation

PawelPlesniak commented Mar 18, 2026

Description

Type of change

List of required branches from other repositories

Change log

Suggested manual testing checklist

Testing

Uh oh!

MRiganSUSX left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PawelPlesniak commented Apr 1, 2026

Uh oh!

PawelPlesniak commented Apr 1, 2026

Uh oh!

emmuhamm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emmuhamm May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MRiganSUSX left a comment •

edited

Loading

emmuhamm May 7, 2026 •

edited

Loading