Merge DFOModule consensus behavior and update peer announcement transport to DFODecision by Copilot · Pull Request #486 · DUNE-DAQ/dfmodules

Copilot · 2026-04-15T12:58:23Z

Inspect current branch state and compare against origin/develop
Run baseline validation commands in this environment (ctest, cmake)
Re-integrate DFOCore logic back into plugins/DFOModule.hpp/.cpp
Keep consensus behavior in DFOModule with minimal edits relative to develop
Remove standalone DFOCore files/tests and update CMake wiring
Update/adjust unit tests/build hygiene impacted by reintegration
Run available post-change validation and summarize environment limits

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/a3b1396a-ba81-4d0d-9afe-944cee92d6ee Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

eflumerf · 2026-04-16T16:21:50Z

@copilot The new module should only inherit from DAQModule. Common DFO code can be moved to library functions in either src or plugins/detail

…helper Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ed628aeb-4879-45d9-b86a-d95d7f541e66 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ed628aeb-4879-45d9-b86a-d95d7f541e66 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot · 2026-04-16T16:46:26Z

@copilot The new module should only inherit from DAQModule. Common DFO code can be moved to library functions in either src or plugins/detail

Done in commit b280c75. DFOConsensusModule now inherits DAQModule directly, with no dependency on DFOModule. All common DFO processing logic (TRB management, slot selection, dispatching, token handling, busy notification, opmon counters) has been extracted into src/dfmodules/DFOCore.hpp/.cpp and added to the library. Both DFOModule and DFOConsensusModule use DFOCore via unique_ptr composition.

eflumerf · 2026-04-16T18:29:22Z

@copilot Add unit tests for DFOCore

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/a1889c64-61e1-42b6-9525-fb129d8e5168 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot · 2026-04-16T18:38:08Z

@copilot Add unit tests for DFOCore

Done in commit 812721a. Added unittest/DFOCore_test.cxx with 12 test cases covering: copy/move semantics, constructor state, configure/start/stop/scrap lifecycle, TRB registration (new_trb_fn callback), TRB reconnect, run-number mismatch handling in tokens and TDs, successful TD dispatch with opmon counters, stop() returning in-flight TDs as remnants, and round-robin/fallback slot selection.

…hang Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/29005214-4521-4327-be2c-9d0620eec67b Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

…g failover Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/8cfa3196-9570-48f5-a552-ad88bae3d298 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

…comments, watchdog logs) Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/8cfa3196-9570-48f5-a552-ad88bae3d298 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

…ments are handled Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ad5ee7fa-bbd5-49fc-8323-82e234ed90b9 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

…_ideas' into copilot/revise-dfo-protocol-resilience

…-protocol-resilience

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/6dddf3f0-ec3c-419b-8dae-33274c5ad7ff Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

…odule Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/6dddf3f0-ec3c-419b-8dae-33274c5ad7ff Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

those test cases.

…-protocol-resilience

eflumerf · 2026-05-01T20:12:49Z

@copilot Fix comments in DFOCore since there is only one DFOModule now. Replace announcement using token with announcement using DFODecision

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/b77498e4-503e-4fa0-bd0a-2f753f95f3a1 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot · 2026-05-01T20:15:44Z

@copilot Fix comments in DFOCore since there is only one DFOModule now. Replace announcement using token with announcement using DFODecision

Implemented in 6f1aeb6. I updated DFOCore comments to refer to the single DFOModule implementation and switched peer announcements from TriggerDecisionToken to DFODecision (send + receive paths, plus updated unit-test injection paths). No UI changes in this PR, so no screenshot applies.

…UNE-DAQ/dfmodules into copilot/revise-dfo-protocol-resilience

…elta Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/3d4ce4e1-702a-4ef6-a91d-014226c3cfed Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

…ne DFOCore Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/3d4ce4e1-702a-4ef6-a91d-014226c3cfed Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/3d4ce4e1-702a-4ef6-a91d-014226c3cfed Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Initial plan

ed8ee63

Copilot AI assigned Copilot and eflumerf Apr 15, 2026

Copilot started work on behalf of eflumerf April 15, 2026 12:58 View session

Copilot AI linked an issue Apr 15, 2026 that may be closed by this pull request

Make the DFO Protocol resilient #428

Open

Copilot finished work on behalf of eflumerf April 15, 2026 14:44

eflumerf closed this Apr 15, 2026

eflumerf removed a link to an issue Apr 15, 2026

Make the DFO Protocol resilient #428

Open

eflumerf reopened this Apr 15, 2026

Copilot started work on behalf of eflumerf April 15, 2026 14:48 View session

Copilot stopped work on behalf of eflumerf due to an error April 15, 2026 15:01
Job was cancelled

Copilot started work on behalf of eflumerf April 15, 2026 15:02 View session

Implement DFO consensus algorithm with deterministic partitioning

d9d2192

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/a3b1396a-ba81-4d0d-9afe-944cee92d6ee Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 15, 2026 15:27

Copilot AI requested a review from eflumerf April 15, 2026 15:27

Copilot started work on behalf of eflumerf April 16, 2026 16:21 View session

Copilot AI and others added 2 commits April 16, 2026 16:43

Refactor: DFOConsensusModule inherits DAQModule directly via DFOCore …

2f51404

…helper Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ed628aeb-4879-45d9-b86a-d95d7f541e66 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

style: use named copy + std::move for peer announcement sends

b280c75

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ed628aeb-4879-45d9-b86a-d95d7f541e66 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Revise DFO protocol to enhance resilience and consensus~~ Revise DFO protocol to enhance resilience and consensus Apr 16, 2026

Copilot finished work on behalf of eflumerf April 16, 2026 16:47

Move source file to src directory

f28114c

Copilot started work on behalf of eflumerf April 16, 2026 18:29 View session

test: add DFOCore unit tests (12 test cases)

812721a

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/a1889c64-61e1-42b6-9525-fb129d8e5168 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 16, 2026 18:39

Copilot started work on behalf of eflumerf April 16, 2026 20:45 View session

fix: register triginh callback in CfgFixture to prevent DFOCore test …

0c800c1

…hang Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/29005214-4521-4327-be2c-9d0620eec67b Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot started work on behalf of eflumerf April 20, 2026 14:24 View session

Copilot AI and others added 2 commits April 20, 2026 14:48

feat: DFODecision broadcast, remote-slot shadow, global busy, watchdo…

c719937

…g failover Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/8cfa3196-9570-48f5-a552-ad88bae3d298 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

fix: address code review comments (atomic snapshot races, clarifying …

aaaee1d

…comments, watchdog logs) Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/8cfa3196-9570-48f5-a552-ad88bae3d298 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 20, 2026 14:53

Copilot started work on behalf of eflumerf April 20, 2026 16:34 View session

fix: start watchdog unconditionally in do_start so late peer announce…

b9d855c

…ments are handled Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ad5ee7fa-bbd5-49fc-8323-82e234ed90b9 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 20, 2026 16:42

eflumerf added 2 commits April 20, 2026 15:17

Merge remote-tracking branch 'origin/kbiery/integtest_verbosity_level…

cb670b7

…_ideas' into copilot/revise-dfo-protocol-resilience

Merge remote-tracking branch 'origin/develop' into copilot/revise-dfo…

c6d966e

…-protocol-resilience

Copilot started work on behalf of eflumerf April 24, 2026 17:47 View session

Copilot AI and others added 2 commits April 24, 2026 17:51

chore: plan merge of DFO modules behind DFOConf consensus flag

067d302

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/6dddf3f0-ec3c-419b-8dae-33274c5ad7ff Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

refactor: merge consensus logic into DFOModule and wrap DFOConsensusM…

dd38668

…odule Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/6dddf3f0-ec3c-419b-8dae-33274c5ad7ff Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 24, 2026 18:04

eflumerf added 2 commits April 24, 2026 15:06

Remove DFOConsensusModule, update DFOModule_test to use consensus for

635283a

those test cases.

Merge remote-tracking branch 'origin/develop' into copilot/revise-dfo…

284f0ad

…-protocol-resilience

Copilot started work on behalf of eflumerf May 1, 2026 20:12 View session

Copilot AI and others added 2 commits May 1, 2026 20:13

chore: plan follow-up for DFO announcement/comment cleanup

b3a1e5a

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/b77498e4-503e-4fa0-bd0a-2f753f95f3a1 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

fix: use DFODecision for peer announcements and update DFO comments

6f1aeb6

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/b77498e4-503e-4fa0-bd0a-2f753f95f3a1 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot AI changed the title ~~Revise DFO protocol to enhance resilience and consensus~~ Merge DFOModule consensus behavior and update peer announcement transport to DFODecision May 1, 2026

Copilot finished work on behalf of eflumerf May 1, 2026 20:16

Merge branch 'copilot/revise-dfo-protocol-resilience' of github.com:D…

51fbbdf

…UNE-DAQ/dfmodules into copilot/revise-dfo-protocol-resilience

Copilot started work on behalf of eflumerf May 12, 2026 19:35 View session

Copilot AI and others added 5 commits May 12, 2026 19:37

chore: plan reintegrate DFOCore into DFOModule with minimal develop d…

6db59e5

…elta Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/3d4ce4e1-702a-4ef6-a91d-014226c3cfed Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

refactor: reintegrate DFO core logic into DFOModule and drop standalo…

54d35de

…ne DFOCore Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/3d4ce4e1-702a-4ef6-a91d-014226c3cfed Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

fix: address review findings and ignore ctest temporary artifacts

5b3864a

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/3d4ce4e1-702a-4ef6-a91d-014226c3cfed Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

style: apply static_cast and prefix decrement cleanup

8bbb6a5

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/3d4ce4e1-702a-4ef6-a91d-014226c3cfed Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

fix: harden retry casting and tighten watchdog loop condition

f26edac

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/3d4ce4e1-702a-4ef6-a91d-014226c3cfed Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf May 12, 2026 19:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge DFOModule consensus behavior and update peer announcement transport to DFODecision#486

Merge DFOModule consensus behavior and update peer announcement transport to DFODecision#486
Copilot wants to merge 27 commits into
developfrom
copilot/revise-dfo-protocol-resilience

Copilot AI commented Apr 15, 2026 •

edited

Loading

Uh oh!

eflumerf commented Apr 16, 2026

Uh oh!

Copilot AI commented Apr 16, 2026

Uh oh!

eflumerf commented Apr 16, 2026

Uh oh!

Copilot AI commented Apr 16, 2026

Uh oh!

eflumerf commented May 1, 2026

Uh oh!

Copilot AI commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eflumerf commented Apr 16, 2026

Uh oh!

Copilot AI commented Apr 16, 2026

Uh oh!

eflumerf commented Apr 16, 2026

Uh oh!

Copilot AI commented Apr 16, 2026

Uh oh!

eflumerf commented May 1, 2026

Uh oh!

Copilot AI commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Apr 15, 2026 •

edited

Loading